Fix order in ExUnit results when listing pinned variables #14723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pinned variables were returned in a reversed alphabetical
order.
test/ex_unit_pinned_variables_order_test.exs:23
match (=) failed
The following variables were pinned:
var_d = "four"
var_c = "three"
var_b = "two"
var_a = "one"
code: assert %{a: ^var_d, b: ^var_c, c: ^var_b, d: ^var_a} = build(var_a, var_b, var_c, var_d)
left: %{a: ^var_d, b: ^var_c, c: ^var_b, d: ^var_a}
right: %{a: "one", b: "two", c: "three", d: "four"}
stacktrace:
test/ex_unit_pinned_variables_order_test.exs:29: (test)
This fix sorts them alphabetically.
This bug was introduced in 884e933 when the pinned vars were now accumulated in a map (instead
of a list), therefore no longer the need to reverse the results.
A repo replicating the issue can be found here:
- https://github.com/eksperimental-debug/elixir_debug/tree/ex-unit-pinned-variables-order
- https://github.com/eksperimental-debug/elixir_debug/blob/ex-unit-pinned-variables-order/ex_unit_pinned_variables_order/test/ex_unit_pinned_variables_order_test.exs
eksperimental
force-pushed
the
fix/ex-unit-pinned-variables-order
branch
from
c9f52d2 to
16c2654
Compare
josevalim
reviewed
Aug 26, 2025
Co-authored-by: José Valim <jose.valim@gmail.com>
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Aug 31, 2025
The pinned variables were returned in a random order (often reversed):
test/ex_unit_pinned_variables_order_test.exs:23
match (=) failed
The following variables were pinned:
var_d = "four"
var_c = "three"
var_b = "two"
var_a = "one"
code: assert %{a: ^var_d, b: ^var_c, c: ^var_b, d: ^var_a} = build(var_a, var_b, var_c, var_d)
left: %{a: ^var_d, b: ^var_c, c: ^var_b, d: ^var_a}
right: %{a: "one", b: "two", c: "three", d: "four"}
stacktrace:
test/ex_unit_pinned_variables_order_test.exs:29: (test)
This fix sorts them alphabetically.
This bug was introduced in 884e933 when the pinned vars were now accumulated in a map (instead
of a list).
A repo replicating the issue can be found here:
- https://github.com/eksperimental-debug/elixir_debug/tree/ex-unit-pinned-variables-order
- https://github.com/eksperimental-debug/elixir_debug/blob/ex-unit-pinned-variables-order/ex_unit_pinned_variables_order/test/ex_unit_pinned_variables_order_test.exs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pinned variables were returned in a reversed alphabetical order.
This fix sorts them alphabetically.
This bug was introduced in 884e933 when the pinned vars were now accumulated in a map (instead of a list), therefore no longer the need to reverse the results.
A repo replicating the issue can be found here: