Skip to content

Conversation

@alainm23
Copy link
Member

@alainm23 alainm23 commented Oct 7, 2024

fix #224

Fixing bug when copying image to clipboard, the bug was replicated on two computers with intel graphics and using Wayland.

@alainm23 alainm23 requested review from a team and danirabbit October 8, 2024 19:21
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce this issue so I can't really test this, but it's still unclear to me why you would still need to add a timeout after already waiting for the clipboard to change and verifying its contents. It seems like just waiting for the clipboard to change should fix the issue

@alainm23
Copy link
Member Author

alainm23 commented Oct 9, 2024

I can't reproduce this issue so I can't really test this, but it's still unclear to me why you would still need to add a timeout after already waiting for the clipboard to change and verifying its contents. It seems like just waiting for the clipboard to change should fix the issue

I understand, but in my case it does not solve it 😭️.

2024-10-09-23.40.24.231763051.mp4

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'm not gonna hold this up. The changes make sense to me and it still works the same here :)

@danirabbit danirabbit merged commit 2aeadad into elementary:main Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Screenshots to clipboard don't paste into many apps like Web, etc. (ctrl+prnt, ctrl+shift+prnt, ctrl+alt+prnt)

2 participants