Fix creating duplicates of unwritable files #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
changed the title
jeremypw
added
the
Good First Issue
zeebok
approved these changes
May 13, 2023
Contributor
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
Looks good. Just the one question but I feel like I am being paranoid 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1316
The issue was caused by the
focus-in-eventhandler checking the file status before the duplicate has been created resulting in a further error dialog. This was fixed by putting the document in aworkingstate while duplicate creation is in progress and ignoring focus in events in that state. The file status is checked after save-as completes instead.