Skip to content

Ensure Replace button (and other search widget) states are mutually consistent #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeremypw merged 3 commits into from
Mar 7, 2023
Merged

Ensure Replace button (and other search widget) states are mutually consistent #1278

jeremypw merged 3 commits into from
Mar 7, 2023

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Feb 27, 2023

Fixes #1266

  • Combine and simplify the 3 functions for updating search widgets to ensure consistency
  • "Replace all" remains sensitive if there are any outstanding matches after first use
  • "Replace" becomes insensitive if there is no focused match (even if matches exist) because Cyclic Search is off.

@jeremypw jeremypw requested a review from a team February 27, 2023 12:54
@jeremypw jeremypw merged commit b847665 into master Mar 7, 2023
@jeremypw jeremypw deleted the fix-replace-sensitivity branch March 7, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeebok zeebok zeebok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Replace All" should not disable the "Replace" and "Replace All" buttons

3 participants

@jeremypw @zeebok