AppButton: Fix drag to dock #640
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
For me the dock doesn't seem to accept DND and can't confirm if the issue is fixed 🤔 Screencast.From.2025-05-29.20-52-56.mp4 |
Member
Author
|
@ryonakano I should mention I'm testing on Wayland. I didn't test for X11 |
Member
|
Yes, I also tested on Wayland. It looks like this not always happens but keeping apps in the dock from the secondary menu does not seem to persistent when it happens and opening the secondary menu again disappear the app from the dock: Screencast.From.2025-05-30.22-10-56.mp4But this disappear issue is reproducible in latest master too (81336c1) thus I don't think it would be a regression from this branch. |
Member
For me this happens about 80% on Wayland and 100% on X, so I can't confirm if this PR does fix the linked issue actually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #614
Don't close the menu until after drag operation is completed