Skip to content

Fix: WidgetMessaging not properly closed causing side effects and bugs#31598

Merged
BillCarsonFr merged 3 commits intodevelopfrom
valere/fix_leaking_widget_messaging
Dec 24, 2025
Merged

Fix: WidgetMessaging not properly closed causing side effects and bugs#31598
BillCarsonFr merged 3 commits intodevelopfrom
valere/fix_leaking_widget_messaging

Conversation

@BillCarsonFr
Copy link
Member

Partial fix #31573

The widgetApi were not properly closed, causing them to leak forever and stil trying to handle requests sent to the WidgetAPI.
Video room widgets are heavily impacted because they keep the same widgetID, so one call to the widgetAPI will be handled by all the leaking objects.

There is playwright test to reproduce 9d56dd9

One call to send message with the widget API can send 3 times the message

image

Checklist

Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also adding the comment on the remove all listeners.

@BillCarsonFr BillCarsonFr added this pull request to the merge queue Dec 24, 2025
Merged via the queue into develop with commit 3f472c8 Dec 24, 2025
42 of 43 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/fix_leaking_widget_messaging branch December 24, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Element Call unexpected reconnections (in loop) every x seconds

3 participants