Fix: WidgetMessaging not properly closed causing side effects and bugs#31598
Merged
BillCarsonFr merged 3 commits intodevelopfrom Dec 24, 2025
Merged
Fix: WidgetMessaging not properly closed causing side effects and bugs#31598BillCarsonFr merged 3 commits intodevelopfrom
BillCarsonFr merged 3 commits intodevelopfrom
Conversation
toger5
approved these changes
Dec 23, 2025
Contributor
toger5
left a comment
There was a problem hiding this comment.
Thanks for also adding the comment on the remove all listeners.
florianduros
approved these changes
Dec 23, 2025
This was referenced Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix #31573
The
widgetApiwere not properly closed, causing them to leak forever and stil trying to handle requests sent to the WidgetAPI.Video room widgets are heavily impacted because they keep the same widgetID, so one call to the widgetAPI will be handled by all the leaking objects.
There is playwright test to reproduce 9d56dd9
One call to send message with the widget API can send 3 times the message
Checklist
public/exportedsymbols have accurate TSDoc documentation.