Make the feedback icon be the right color in dark theme#31527
Merged
t3chguy merged 1 commit intoelement-hq:developfrom Dec 12, 2025
Merged
Make the feedback icon be the right color in dark theme#31527t3chguy merged 1 commit intoelement-hq:developfrom
t3chguy merged 1 commit intoelement-hq:developfrom
Conversation
Our feedback.svg is not tintable. Rather than mess with it I think it makes sense to use the equivalent Compound icon.
t3chguy
approved these changes
Dec 12, 2025
Member
t3chguy
left a comment
There was a problem hiding this comment.
https://docs.google.com/spreadsheets/d/1nYbTWwG3TPnh70LX5looxpCiWuLhW0TYEZFIxVjYALY/edit?gid=2146012360#gid=2146012360 asks for this icon to be ChatProblem instead but will accept for now and query after given it is similar to the old icon
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-staging staging
# Navigate to the new working tree
cd .worktrees/backport-staging
# Create a new branch
git switch --create backport-31527-to-staging
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 179cf0f8e17ee0d284b88e72946f2ef2b25e8514
# Push it to GitHub
git push --set-upstream origin backport-31527-to-staging
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-stagingThen, create a pull request where the |
Member
|
Doesn't affect the RC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our feedback.svg is not tintable. Rather than mess with it I think it makes sense to use the equivalent Compound icon.