Skip to content

Make the feedback icon be the right color in dark theme#31527

Merged
t3chguy merged 1 commit intoelement-hq:developfrom
robintown:feedback-icon
Dec 12, 2025
Merged

Make the feedback icon be the right color in dark theme#31527
t3chguy merged 1 commit intoelement-hq:developfrom
robintown:feedback-icon

Conversation

@robintown
Copy link
Member

Our feedback.svg is not tintable. Rather than mess with it I think it makes sense to use the equivalent Compound icon.

Before After
Screenshot 2025-12-12 at 00-14-34 Element 4 Test room Screenshot 2025-12-12 at 00-14-26 Element 3

Our feedback.svg is not tintable. Rather than mess with it I think it makes sense to use the equivalent Compound icon.
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.google.com/spreadsheets/d/1nYbTWwG3TPnh70LX5looxpCiWuLhW0TYEZFIxVjYALY/edit?gid=2146012360#gid=2146012360 asks for this icon to be ChatProblem instead but will accept for now and query after given it is similar to the old icon

@t3chguy t3chguy added the backport staging Label to automatically backport PR to staging branch label Dec 12, 2025
@t3chguy t3chguy added this pull request to the merge queue Dec 12, 2025
Merged via the queue into element-hq:develop with commit 179cf0f Dec 12, 2025
48 checks passed
@RiotRobot
Copy link
Contributor

The backport to staging failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-staging staging
# Navigate to the new working tree
cd .worktrees/backport-staging
# Create a new branch
git switch --create backport-31527-to-staging
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 179cf0f8e17ee0d284b88e72946f2ef2b25e8514
# Push it to GitHub
git push --set-upstream origin backport-31527-to-staging
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-staging

Then, create a pull request where the base branch is staging and the compare/head branch is backport-31527-to-staging.

@t3chguy t3chguy removed the backport staging Label to automatically backport PR to staging branch label Dec 12, 2025
@t3chguy
Copy link
Member

t3chguy commented Dec 12, 2025

Doesn't affect the RC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants