Implement UI for history visibility acknowledgement.#31156
Merged
kaylendog merged 62 commits intoelement-hq:developfrom Dec 10, 2025
Merged
Implement UI for history visibility acknowledgement.#31156kaylendog merged 62 commits intoelement-hq:developfrom
kaylendog merged 62 commits intoelement-hq:developfrom
Conversation
kaylendog
commented
Nov 3, 2025
florianduros
reviewed
Nov 3, 2025
florianduros
reviewed
Nov 3, 2025
kaylendog
force-pushed
the
kaylendog/history-sharing/status
branch
from
68ef636 to
27b11e4
Compare
Contributor
Author
|
I'm wondering if this would be better off as a floating alert above the UI - would conflict less with the identity reset dialog. |
Member
|
@kaylendog this is a question for the design team. Where are the figma design for this banner? |
Contributor
Author
Here (for EW)! |
Contributor
Author
|
Opening this up for review, since I can't make any headway on the CI failures:
|
florianduros
requested changes
Nov 5, 2025
Member
florianduros
left a comment
florianduros
left a comment
There was a problem hiding this comment.
Each components in shared component has its own folder. imo RoomStatusBarHistoryVisible should be in packages/shared-components/src/room/RoomStatusBarHistoryVisible.
The RoomStatusBarHistoryVisible is missing at least a render test and a check that onClose is correctly binded.
...ared-components/src/room/RoomStatusBarHistoryVisible/RoomStatusBarHistoryVisible.stories.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/structures/RoomStatusBarHistoryVisible.stories.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/structures/RoomStatusBarHistoryVisible.module.css
Outdated
Show resolved
Hide resolved
packages/shared-components/src/structures/RoomStatusBarHistoryVisible.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/structures/RoomStatusBarHistoryVisible.tsx
Outdated
Show resolved
Hide resolved
florianduros
requested changes
Dec 5, 2025
| return ( | ||
| <Tooltip open={isTooltipOpen} description={formatTimeLeft(secondsLeft)} placement="bottom"> | ||
| <div className={classes} ref={this.ref} role="region" aria-label={_t("a11y|message_composer")}> | ||
| <HistoryVisibleBannerView vm={new HistoryVisibleBannerViewModel({ room: this.props.room })} /> |
Member
There was a problem hiding this comment.
At every render of the MessageComposer, the vm will be recreated. We want to avoid that.
You can:
- Create the vm in the message component (constructor/componentDidMount), put in the state, dispose the vm in componentWillUnMount
- Create a functional component where you create the vm with Introduce a hook to auto dispose view models #31178 and render the view
Comment on lines
26
to
27
| private readonly featureWatcher: string; | ||
| private readonly acknowledgedWatcher: string; |
florianduros
approved these changes
Dec 9, 2025
kaylendog
added a commit
that referenced
this pull request
Jan 26, 2026
This reverts commit cff9119.
kaylendog
added a commit
that referenced
this pull request
Jan 26, 2026
This reverts commit cff9119.
kaylendog
added a commit
that referenced
this pull request
Jan 26, 2026
This reverts commit cff9119.
kaylendog
added a commit
that referenced
this pull request
Jan 26, 2026
This reverts commit cff9119.
kaylendog
added a commit
that referenced
this pull request
Jan 26, 2026
This reverts commit cff9119.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
* Revert "Update algorithm for history visible banner. (#31577)" This reverts commit ce9c66b. * Revert "Update prop type & documentation for HistoryVisibleBanner and VM. (#31545)" This reverts commit 4da149e. * Revert "Prevent history visible banner from displaying in threads. (#31535)" This reverts commit c7134e8. * Revert "Implement UI for history visibility acknowledgement. (#31156)" This reverts commit cff9119.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows a banner above the message composer whenever a user opens a room with non-join history visibility, which they can dismiss.
Issue: element-hq/element-meta#2875
Checklist
public/exportedsymbols have accurate TSDoc documentation.