This repository was archived by the owner on Oct 2, 2023. It is now read-only.
Update config and fix config naming. #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Messed up the last commit: the "bump the version" commit actually also makes a breaking change to the bundle format to get rid of the named import { data as bundle } from '../migrations/dist'We just have: import bundle from '../migrations/dist' |
thruflo
force-pushed
the
thruflo/app-and-env
branch
from
3b0f9bd to
af3c35a
Compare
icehaunter
force-pushed
the
thruflo/app-and-env
branch
from
af3c35a to
944d0d0
Compare
Contributor
|
Please add |
Contributor
Author
Relates to [VAX-518] but doesn't close it without other PRs across repos. |
Not app-id, or APP_ID or environment or ENVIROMENT_NAME or any other variant.
- `app` is configured using the `APP` argument or `-a, -app APP` option
- `env` is configured using the `-e, --env ENV` option
The electric.json data uses the naming:
```
{
app: APP,
env: ENV,
migrations: PATH
}
```
Particularly to make sure that the data in the electric.json matches the naming
that we use in the docs and the client.
</end-rant>
thruflo
force-pushed
the
thruflo/app-and-env
branch
from
71dd366 to
c1ea43d
Compare
icehaunter
approved these changes
Jan 24, 2023
Contributor
icehaunter
left a comment
icehaunter
left a comment
There was a problem hiding this comment.
I have not looked through +4,826 −2,826 changes, but I did play around with updated commands locally. It seems to work. I've raised a couple of non-blocking concerns on Discord
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support:
Fix naming to use
appandenveverywhere, including theelectric.json. And update the README to match latest usage.