Skip to content

Conversation

@icehaunter
Copy link
Contributor

Closes #3657

@icehaunter icehaunter requested a review from robacourt January 12, 2026 17:20
@codecov
Copy link

codecov bot commented Jan 12, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2040 1 2039 0
View the top 3 failed test(s) by shortest run time
Elixir.Electric.Plug.RouterTest::test secure mode allows access to /v1/health without secret
Stack Traces | 2.06s run time
2) test secure mode allows access to /v1/health without secret (Electric.Plug.RouterTest)
     .../electric/plug/router_test.exs:3293
     Assertion failed, no matching message after 2000ms
     The following variables were pinned:
       ref = #Reference<0.1384138126.2533359619.27800>
     Showing 1 of 1 message in the mailbox
     code: assert_receive {:stack_status, ^ref, :ready}
     mailbox:
       pattern: {:stack_status, ^ref, :ready}
       value:   {:stack_status, #Reference<0.1384138126.2533359619.27800>, {:connection_error, %{error: "%Postgrex.Error{\n  message: nil,\n  postgres: %{\n    code: :too_many_connections,\n    line: \"359\",\n    message: \"sorry, too many clients already\",\n    file: \"proc.c\",\n    unknown: \"FATAL\",\n    severity: \"FATAL\",\n    pg_code: \"53300\",\n    routine: \"InitProcess\"\n  },\n  connection_id: nil,\n  query: nil\n}", message: "sorry, too many clients already", type: :insufficient_resources, total_retry_time: 0}}}
     stacktrace:
       (electric 1.2.11) test/support/component_setup.ex:462: Support.ComponentSetup.with_complete_stack/1
       Electric.Plug.RouterTest.__ex_unit_describe_8/1
Elixir.Electric.Plug.RouterTest::test /v1/shapes - admission control tracks initial and existing requests separately
Stack Traces | 2.06s run time
1) test /v1/shapes - admission control tracks initial and existing requests separately (Electric.Plug.RouterTest)
     .../electric/plug/router_test.exs:2129
     Assertion failed, no matching message after 2000ms
     The following variables were pinned:
       ref = #Reference<0.623362914.4144234498.138509>
     Showing 1 of 1 message in the mailbox
     code: assert_receive {:stack_status, ^ref, :ready}
     mailbox:
       pattern: {:stack_status, ^ref, :ready}
       value:   {:stack_status, #Reference<0.623362914.4144234498.138509>, {:connection_error, %{error: "%Postgrex.Error{\n  message: nil,\n  postgres: %{\n    code: :too_many_connections,\n    line: \"357\",\n    message: \"sorry, too many clients already\",\n    file: \"proc.c\",\n    unknown: \"FATAL\",\n    severity: \"FATAL\",\n    pg_code: \"53300\",\n    routine: \"InitProcess\"\n  },\n  connection_id: nil,\n  query: nil\n}", message: "sorry, too many clients already", type: :insufficient_resources, total_retry_time: 0}}}
     stacktrace:
       (electric 1.2.11) test/support/component_setup.ex:462: Support.ComponentSetup.with_complete_stack/1
       Electric.Plug.RouterTest.__ex_unit_describe_4/1
Elixir.Electric.Plug.RouterTest::test /v1/shapes GET splits up updates into 2 operations if PK was changed
Stack Traces | 2.07s run time
1) test /v1/shapes GET splits up updates into 2 operations if PK was changed (Electric.Plug.RouterTest)
     .../electric/plug/router_test.exs:886
     Assertion failed, no matching message after 2000ms
     The following variables were pinned:
       ref = #Reference<0.1384138126.2533359619.28496>
     Showing 1 of 1 message in the mailbox
     code: assert_receive {:stack_status, ^ref, :ready}
     mailbox:
       pattern: {:stack_status, ^ref, :ready}
       value:   {:stack_status, #Reference<0.1384138126.2533359619.28496>, {:connection_error, %{error: "%Postgrex.Error{\n  message: nil,\n  postgres: %{\n    code: :too_many_connections,\n    line: \"359\",\n    message: \"sorry, too many clients already\",\n    file: \"proc.c\",\n    unknown: \"FATAL\",\n    severity: \"FATAL\",\n    pg_code: \"53300\",\n    routine: \"InitProcess\"\n  },\n  connection_id: nil,\n  query: nil\n}", message: "sorry, too many clients already", type: :insufficient_resources, total_retry_time: 0}}}
     stacktrace:
       (electric 1.2.11) test/support/component_setup.ex:462: Support.ComponentSetup.with_complete_stack/1
       Electric.Plug.RouterTest.__ex_unit_describe_3/1

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@blacksmith-sh
Copy link
Contributor

blacksmith-sh bot commented Jan 12, 2026

Found 3 test failures on Blacksmith runners:

Failures

Test View Logs
Elixir.Electric.Plug.RouterTest/test /v1/
shapes - admission control tracks initial and existing requests separately
View Logs
Elixir.Electric.Plug.RouterTest/test /v1/
shapes GET splits up updates into 2 operations if PK was changed
View Logs
Elixir.Electric.Plug.RouterTest/test secure mode allows access to /v1/
health without secret
View Logs

Fix in Cursor

@icehaunter icehaunter force-pushed the ilia/pr/nqulpnosskrt branch from 651dde3 to a03a7de Compare January 13, 2026 13:21
@netlify
Copy link

netlify bot commented Jan 13, 2026

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit a03a7de
🔍 Latest deploy log https://app.netlify.com/projects/electric-next/deploys/696646c803c1f2000876bdd2
😎 Deploy Preview https://deploy-preview-3695--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subqueries error: Shape terminated before snapshot was ready

2 participants