Skip to content

Conversation

@tjenkinson
Copy link

👋 hey!

Was looking through the code and it doesn't look like this is used anywhere, and I think the existing logic that cleans up based on xmaxSnapshots should cover it?

I think the intention was to use the global_last_seen_lsn added in #3159

See this discussion on discord

Copilot AI review requested due to automatic review settings January 10, 2026 12:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused snapshot cleanup functionality from the TypeScript client's snapshot tracker that was never integrated into the actual implementation. The cleanup logic based on xmaxSnapshots already provides the necessary functionality.

Changes:

  • Removed unused snapshotsByDatabaseLsn tracking map and related logic from SnapshotTracker
  • Removed unused lastSeenUpdate method that was never called in the codebase
  • Removed the corresponding test for the unused lastSeenUpdate functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/typescript-client/src/snapshot-tracker.ts Removed unused snapshotsByDatabaseLsn map, removed tracking logic in addSnapshot, and removed the lastSeenUpdate method
packages/typescript-client/test/snapshot-tracker.test.ts Removed test for the unused lastSeenUpdate method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant