fix: Respect markAsReadOnScroll setting#260
Closed
NikolaM-Dev wants to merge 1 commit intoelecth:mainfrom
Closed
Conversation
30b8c4f to
c5abdf7
Compare
Owner
|
Thanks for the detailed report. This behavior is actually by design. When navigating with the j/k keyboard shortcuts, the app assumes that jumping to an article indicates you have intentionally viewed it, so the item is marked as read regardless of the markAsReadOnScroll setting. The scroll-based setting only governs automatic read marking during passive scrolling. |
Author
Ohh, that makes sense, thanks for clarifying! And kudos to you for the thoughtful UX here. I actually really appreciate having that level of control, so this works perfectly for my use case. No issue at all on my end 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
markAsReadOnScrollis disabled, articles were still being incorrectly marked as read when users jumped through the chat using thejandkkeyboard shortcuts. The jump navigation was bypassing the setting check.Solution
Added validation in the
useHotkeyshook to respect themarkAsReadOnScrollsetting during keyboard jump navigation. Now when users pressjork, we check the setting before marking articles as read—consistent with scroll behavior.Changes Made
useHotkeyshook: Added check formarkAsReadOnScrollbefore marking messages as read onj/kjumpsTesting
markAsReadOnScroll, usedj/kto jump—articles no longer auto-mark as readmarkAsReadOnScroll, verifiedj/kjumps also mark as read (expected behavior)