Skip to content

Comments

fix: Respect markAsReadOnScroll setting#260

Closed
NikolaM-Dev wants to merge 1 commit intoelecth:mainfrom
NikolaM-Dev:fix/respect-mark-as-read-on-scroll-setting
Closed

fix: Respect markAsReadOnScroll setting#260
NikolaM-Dev wants to merge 1 commit intoelecth:mainfrom
NikolaM-Dev:fix/respect-mark-as-read-on-scroll-setting

Conversation

@NikolaM-Dev
Copy link

@NikolaM-Dev NikolaM-Dev commented Feb 20, 2026

Problem

When markAsReadOnScroll is disabled, articles were still being incorrectly marked as read when users jumped through the chat using the j and k keyboard shortcuts. The jump navigation was bypassing the setting check.

Solution

Added validation in the useHotkeys hook to respect the markAsReadOnScroll setting during keyboard jump navigation. Now when users press j or k, we check the setting before marking articles as read—consistent with scroll behavior.

Changes Made

  • useHotkeys hook: Added check for markAsReadOnScroll before marking messages as read on j/k jumps

Testing

  • Disabled markAsReadOnScroll, used j/k to jump—articles no longer auto-mark as read
  • Enabled markAsReadOnScroll, verified j/k jumps also mark as read (expected behavior)

@NikolaM-Dev NikolaM-Dev force-pushed the fix/respect-mark-as-read-on-scroll-setting branch from 30b8c4f to c5abdf7 Compare February 20, 2026 02:18
@electh
Copy link
Owner

electh commented Feb 20, 2026

Thanks for the detailed report.

This behavior is actually by design. When navigating with the j/k keyboard shortcuts, the app assumes that jumping to an article indicates you have intentionally viewed it, so the item is marked as read regardless of the markAsReadOnScroll setting. The scroll-based setting only governs automatic read marking during passive scrolling.

@NikolaM-Dev
Copy link
Author

This behavior is actually by design...

Ohh, that makes sense, thanks for clarifying! And kudos to you for the thoughtful UX here. I actually really appreciate having that level of control, so this works perfectly for my use case. No issue at all on my end 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants