-
Notifications
You must be signed in to change notification settings - Fork 477
[GCP] [Billing] Improve documentation #9931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
audit |
2192.98 | 1692.05 | -500.93 (-22.84%) | 💔 |
dns |
3030.3 | 2237.14 | -793.16 (-26.17%) | 💔 |
vpcflow |
3984.06 | 3344.48 | -639.58 (-16.05%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor editing suggestions, otherwise LGTM.
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
💚 Build Succeeded
History
cc @gpop63 |
|
Package gcp - 2.37.1 containing this change is available at https://epr.elastic.co/search?package=gcp |
* improve docs * bump package version * fix pr id * add cost_type in docs * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * address reviews * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * Update packages/gcp/docs/billing.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * remove newline --------- Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
* improve docs * bump package version * fix pr id * add cost_type in docs * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * address reviews * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * Update packages/gcp/docs/billing.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * remove newline --------- Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
Overview
Improves GCP Billing documentation to clarify what each config param means.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots