Skip to content

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented May 21, 2024

Overview

Improves GCP Billing documentation to clarify what each config param means.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 self-assigned this May 21, 2024
@elasticmachine
Copy link

elasticmachine commented May 21, 2024

🚀 Benchmarks report

Package gcp 👍(1) 💚(2) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2192.98 1692.05 -500.93 (-22.84%) 💔
dns 3030.3 2237.14 -793.16 (-26.17%) 💔
vpcflow 3984.06 3344.48 -639.58 (-16.05%) 💔

To see the full report comment with /test benchmark fullreport

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@gpop63 gpop63 marked this pull request as ready for review May 21, 2024 20:25
@gpop63 gpop63 requested review from a team as code owners May 21, 2024 20:25
@botelastic
Copy link

botelastic bot commented Jun 26, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 26, 2024
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@botelastic botelastic bot removed the Stalled label Jul 18, 2024
gpop63 and others added 5 commits July 18, 2024 11:45
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@gpop63 gpop63 requested review from shmsr and ishleenk17 July 18, 2024 09:55
@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Jul 19, 2024
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor editing suggestions, otherwise LGTM.

gpop63 and others added 3 commits August 12, 2024 18:05
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @gpop63

Copy link

@gpop63 gpop63 merged commit 4448989 into elastic:main Aug 12, 2024
5 checks passed
@elasticmachine
Copy link

Package gcp - 2.37.1 containing this change is available at https://epr.elastic.co/search?package=gcp

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* improve docs

* bump package version

* fix pr id

* add cost_type in docs

* Update packages/gcp/_dev/build/docs/billing.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/gcp/_dev/build/docs/billing.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/gcp/_dev/build/docs/billing.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/gcp/_dev/build/docs/billing.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* address reviews

* Update packages/gcp/_dev/build/docs/billing.md

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

* Update packages/gcp/docs/billing.md

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

* remove newline

---------

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* improve docs

* bump package version

* fix pr id

* add cost_type in docs

* Update packages/gcp/_dev/build/docs/billing.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/gcp/_dev/build/docs/billing.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/gcp/_dev/build/docs/billing.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/gcp/_dev/build/docs/billing.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* address reviews

* Update packages/gcp/_dev/build/docs/billing.md

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

* Update packages/gcp/docs/billing.md

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

* remove newline

---------

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:gcp Google Cloud Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve GCP Billing docs
7 participants