Skip to content

Conversation

endorama
Copy link
Member

Proposed commit message

Revert "[Universal profiling symbolizer] use secrets variables (#9807)"

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@endorama endorama requested a review from a team as a code owner May 14, 2024 08:42
@inge4pres
Copy link
Contributor

Question for the Fleet team (@kpollich ?): what happens if we don't upgrade the version, but still perform a rollback to the previous format?
Is the 8.14.0 version going to be overridden in EPR after merge?

That would solve our problem immediately.

@inge4pres inge4pres requested a review from kpollich May 14, 2024 08:46
@endorama
Copy link
Member Author

@inge4pres I remember versions are immutable once released, so we would end up with 8.14.0 remaining the same.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

@endorama endorama merged commit 718f3ce into main May 14, 2024
@endorama endorama deleted the revert-9807 branch May 14, 2024 09:41
@elasticmachine
Copy link

Package profiler_symbolizer - 8.14.1 containing this change is available at https://epr.elastic.co/search?package=profiler_symbolizer

@andrewkroh andrewkroh added the Integration:universal_profiling_symbolizer Universal Profiling Symbolizer label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:universal_profiling_symbolizer Universal Profiling Symbolizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants