-
Notifications
You must be signed in to change notification settings - Fork 476
[Oracle] Add global filter in dashboard for Oracle #9655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Oracle] Add global filter in dashboard for Oracle #9655
Conversation
🚀 Benchmarks reportTo see the full report comment with |
The PR looks good to me. |
Sure, working on generating data to populate dashboards so I can keep the Before vs After screenshot in description, so PR reviewer can see the changes on Screenshot. |
packages/oracle/changelog.yml
Outdated
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "1.24.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 1.25.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
1.25.0
?
Agree, It should be minor version increment!
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Since there are multiple datasets in the filter condition, do you want to consider using a Custom Filter Label ? ![]() @tommyers-elastic , what do you think? If the approach is good, can this be used as the default approach for all changes mentioned here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package oracle - 1.25.0 containing this change is available at https://epr.elastic.co/search?package=oracle |
* add datastream filter in dashboard * update changelog with pr link * update minor version
* add datastream filter in dashboard * update changelog with pr link * update minor version
* add datastream filter in dashboard * update changelog with pr link * update minor version
Proposed commit message
Add a global filter to the dashboard and remove the subfilters on the dataset and a global filter on the dataset is introduced. Filters on data_stream.dataset are applied with a phrase type filter on the dataset that is being used in that particular dashboard.
Checklist
changelog.yml
file.Related issues
Screenshot
Memory Metrics
Before:
After:
Sysmetric
Before:
After:
System Statistics Metrics
Before:
After:
Overview
Before:
After:
Performance Metrics
Before:
After:
Tablespace
Before:
After: