Skip to content

Conversation

milan-elastic
Copy link
Contributor

@milan-elastic milan-elastic commented Apr 20, 2024

Proposed commit message

Add a global filter to the dashboard and remove the subfilters on the dataset and a global filter on the dataset is introduced. Filters on data_stream.dataset are applied with a phrase type filter on the dataset that is being used in that particular dashboard.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshot

Memory Metrics

Before:

Memory Metrics - before

After:

Memory Metrics - after

Sysmetric

Before:

Sysmetric - before

After:

Sysmetric - after

System Statistics Metrics

Before:

System Statistics Metrics - before

After:

System Statistics Metrics - after

Overview

Before:

Overview - before

After:

Overview - after

Performance Metrics

Before:

Performance Metrics - before

After:

Performance Metrics - after

Tablespace

Before:

Tablespace - before

After:

Tablespace - after

@elasticmachine
Copy link

elasticmachine commented Apr 20, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@agithomas
Copy link
Contributor

The PR looks good to me.
Please do the needful such that we can merge the changes soon.

@milan-elastic
Copy link
Contributor Author

The PR looks good to me. Please do the needful such that we can merge the changes soon.

Sure, working on generating data to populate dashboards so I can keep the Before vs After screenshot in description, so PR reviewer can see the changes on Screenshot.

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.24.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 1.25.0?

Copy link
Contributor Author

@milan-elastic milan-elastic Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 1.25.0?

Agree, It should be minor version increment!

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @milan-elastic

@milan-elastic milan-elastic marked this pull request as ready for review April 22, 2024 10:09
@milan-elastic milan-elastic requested a review from a team as a code owner April 22, 2024 10:09
@milan-elastic milan-elastic requested a review from agithomas April 22, 2024 10:09
Copy link
Contributor

@harnish-crest-data harnish-crest-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@agithomas
Copy link
Contributor

agithomas commented Apr 22, 2024

Since there are multiple datasets in the filter condition, do you want to consider using a Custom Filter Label ?

image

@tommyers-elastic , what do you think?

If the approach is good, can this be used as the default approach for all changes mentioned here?

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

Package oracle - 1.25.0 containing this change is available at https://epr.elastic.co/search?package=oracle

gizas pushed a commit that referenced this pull request Apr 26, 2024
* add datastream filter in dashboard

* update changelog with pr link

* update minor version
@niraj-elastic niraj-elastic mentioned this pull request May 29, 2024
4 tasks
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
* add datastream filter in dashboard

* update changelog with pr link

* update minor version
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
* add datastream filter in dashboard

* update changelog with pr link

* update minor version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants