[jamf_compliance_reporter] Clean up null handling, other checks, scripting #9179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisberkhout
added
Team:Service-Integrations
39 tasks
chrisberkhout
changed the title
🚀 Benchmarks reportTo see the full report comment with |
efd6
reviewed
Feb 18, 2024
...f_compliance_reporter/data_stream/log/elasticsearch/ingest_pipeline/pipeline_app_metrics.yml
Outdated
Show resolved
Hide resolved
...es/jamf_compliance_reporter/data_stream/log/elasticsearch/ingest_pipeline/pipeline_event.yml
Show resolved
Hide resolved
…h/ingest_pipeline/pipeline_app_metrics.yml Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
chrisberkhout
commented
Feb 20, 2024
...f_compliance_reporter/data_stream/log/elasticsearch/ingest_pipeline/pipeline_app_metrics.yml
Show resolved
Hide resolved
💚 Build Succeeded
History
|
|
98.2% Coverage on New Code
0.0% Duplication on New Code
efd6
approved these changes
Feb 21, 2024
|
Package jamf_compliance_reporter - 1.11.2 containing this change is available at https://epr.elastic.co/search?package=jamf_compliance_reporter |
gizas
pushed a commit
that referenced
this pull request
Mar 13, 2024
…pting (#9179) - Combine 'not null and is/not value' checks. - Remove redundant null-safe operator. - Add 'not null' check to 'not value' checks. - Correct date conversion conditions to check source values. - Add 'not null' check before .entrySet(). - Avoid trying to cast null to long/int. --------- Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
qcorporation
pushed a commit
that referenced
this pull request
Feb 3, 2025
…pting (#9179) - Combine 'not null and is/not value' checks. - Remove redundant null-safe operator. - Add 'not null' check to 'not value' checks. - Correct date conversion conditions to check source values. - Add 'not null' check before .entrySet(). - Avoid trying to cast null to long/int. --------- Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
qcorporation
pushed a commit
that referenced
this pull request
Feb 4, 2025
…pting (#9179) - Combine 'not null and is/not value' checks. - Remove redundant null-safe operator. - Add 'not null' check to 'not value' checks. - Correct date conversion conditions to check source values. - Add 'not null' check before .entrySet(). - Avoid trying to cast null to long/int. --------- Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Related issues
nullhandling inifconditions and elsewhere #8646