profiling: customize metrics exposition in collector/symbolizer #8582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
inge4pres
force-pushed
the
profiluing/customize-metrics-config
branch
from
b85f2ac to
2569408
Compare
florianl
requested changes
Nov 30, 2023
packages/universal_profiling_collector/agent/input/input.yml.hbs
Outdated
Show resolved
Hide resolved
packages/universal_profiling_collector/agent/input/input.yml.hbs
Outdated
Show resolved
Hide resolved
packages/universal_profiling_collector/agent/input/input.yml.hbs
Outdated
Show resolved
Hide resolved
packages/universal_profiling_collector/agent/input/input.yml.hbs
Outdated
Show resolved
Hide resolved
packages/universal_profiling_symbolizer/agent/input/input.yml.hbs
Outdated
Show resolved
Hide resolved
inge4pres
force-pushed
the
profiluing/customize-metrics-config
branch
from
f71cfd2 to
14ca2c0
Compare
Thanks! great idea 👍🏼 |
florianl
approved these changes
Dec 1, 2023
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co> Co-authored-by: Florian Lehner <florianl@users.noreply.github.com> Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
inge4pres
force-pushed
the
profiluing/customize-metrics-config
branch
from
14ca2c0 to
8cc8e87
Compare
|
Package profiler_collector - 8.12.0 containing this change is available at https://epr.elastic.co/search?package=profiler_collector |
|
Package profiler_symbolizer - 8.12.0 containing this change is available at https://epr.elastic.co/search?package=profiler_symbolizer |
florianl
added a commit
to elastic/kibana
that referenced
this pull request
Dec 4, 2023
## Summary With elastic/integrations#8582 the integration packages for Universal Profiling got upgraded. With Kibana bundle these new integration packages. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
andrewkroh
added
Integration:universal_profiling_collector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
We implement a new configuration structure for exposing the configuration of application metrics.
Users will be able to customize the HTTP endpoints for both Prometheus and expvar metrics.
Since we are going to release a beta for Profiling Self-Managed (running on-prem), these new configuration options will allow users to monitor more effectively their Profiling backend installations.
Checklist
changelog.ymlfile.How to test this PR locally
Build the package with
elastic-package, deploy to a local instance of Kibana and deploy the integrations through the details page.Related issues
https://github.com/elastic/prodfiler/issues/4140