Skip to content

[O11y][AWS] Migrate AWS Redshift dashboard input controls #6865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 19, 2023
Merged

[O11y][AWS] Migrate AWS Redshift dashboard input controls #6865

merged 4 commits into from
Jul 19, 2023

Conversation

kush-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Manually migrate AWS Redshift dashboard visualizations to the lens in the current Kibana version 8.8.1 itself.

  • Statistics for AWS Redshift dashboard Lens migration:

AWS Redshift Dashboards Before Migration       After Migration      
  Control Panel Search Lens Visualization New Controls Search Lens Visualization
[Metrics AWS] Redshift metrics overview 1 0 16 0 1 0 16 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.8.1 itself.

Related issues

@kush-elastic kush-elastic requested review from a team as code owners July 7, 2023 11:16
@elasticmachine
Copy link

elasticmachine commented Jul 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-19T07:39:41.068+0000

  • Duration: 51 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 7, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 85.714% (240/280) 👍 12.987
Lines 85.925% (7387/8597) 👎 -14.075
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic self-assigned this Jul 7, 2023
@kush-elastic kush-elastic added the enhancement New feature or request label Jul 7, 2023
rajvi-patel-22
rajvi-patel-22 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Jul 10, 2023
Closed
5 tasks
@drewdaemon
Copy link
Contributor

Nice work. Can we swap out those legacy metric visualizations for the normal Lens metric?

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Jul 11, 2023
Closed
24 tasks
@kush-elastic
Copy link
Contributor Author

Nice work. Can we swap out those legacy metric visualizations for the normal Lens metric?

@drewdaemon, I have created a separate backlog issue (#6909) to track this and will raise separate PR for converting those visualizations to new metric.

mbondyra
mbondyra approved these changes Jul 11, 2023
View reviewed changes
Copy link

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, seeing that the metrics will be swapped separately 🙆🏼‍♀️

@kush-elastic
Copy link
Contributor Author

The dashboards are exported from 8.7.0 due to export issue from 8.8.x (elastic/elastic-package#1354)

@kush-elastic
Merge branch 'main' of https://github.com/kush-elastic/integrations i…
2782fe3 
…nto lens_migration-aws-redshift

Conflicts:
	packages/aws/changelog.yml
	packages/aws/manifest.yml
@rajvi-patel-22 rajvi-patel-22 merged commit 9d4bcaa into elastic:main Jul 19, 2023
@elasticmachine
Copy link

Package aws - 1.47.1 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

+1 more reviewer

@rajvi-patel-22 rajvi-patel-22 rajvi-patel-22 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kush-elastic kush-elastic

Labels
enhancement New feature or request Integration:aws AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][AWS] AWS Redshift Lens Migration
7 participants
@kush-elastic @elasticmachine @drewdaemon @mbondyra @kaiyan-sheng @rajvi-patel-22 @andrewkroh