Skip to content

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 24, 2023

What does this PR do?

This extracts provider names from the evidence details fields in order to populate threat.indicator.provider.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Apr 24, 2023
@efd6 efd6 force-pushed the 5960-ti_recordedfuture branch 2 times, most recently from 8c43866 to cc178fe Compare April 24, 2023 01:20
@elasticmachine
Copy link

elasticmachine commented Apr 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-24T01:34:08.431+0000

  • Duration: 16 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 force-pushed the 5960-ti_recordedfuture branch from cc178fe to f5f4d45 Compare April 24, 2023 01:33
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (17/17) 💚
Lines 97.585% (202/207) 👍 2.302
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review April 24, 2023 02:35
@efd6 efd6 requested a review from a team as a code owner April 24, 2023 02:35
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit e649e07 into elastic:main Apr 26, 2023
@elasticmachine
Copy link

Package ti_recordedfuture - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=ti_recordedfuture

@efd6 efd6 deleted the 5960-ti_recordedfuture branch February 5, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:ti_recordedfuture Recorded Future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ti_recordedfuture] Missing threat.indicator.provider
3 participants