Skip to content

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 30, 2023

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jan 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-30T22:44:44.183+0000

  • Duration: 17 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 43
Skipped 0
Total 43

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jan 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.284
Classes 100.0% (2/2) 💚 2.284
Methods 100.0% (36/36) 💚 8.538
Lines 76.15% (2880/3782) 👎 -16.714
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review January 30, 2023 08:21
@efd6 efd6 requested a review from a team as a code owner January 30, 2023 08:21
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit 6de1119 into elastic:main Jan 31, 2023
@elasticmachine
Copy link

Package cisco_asa - 2.13.0 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

@elasticmachine
Copy link

Package cisco_ftd - 2.9.0 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd

@efd6 efd6 deleted the 5080-cisco branch February 5, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:cisco_asa Cisco ASA Integration:cisco_ftd Cisco FTD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants