-
Notifications
You must be signed in to change notification settings - Fork 476
Fix Dashboard Links Panel filter options for elastic/obs-infraobs-integrations
packages
#14974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportTo see the full report comment with |
packages/iis/changelog.yml
Outdated
changes: | ||
- description: Fix Dashboard Links Panel by setting `useCurrentFilters` to `false` | ||
type: bugfix | ||
link: https://github.com/elastic/integrations/pull/14607 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix this for the rest of the integrations as well?
link: https://github.com/elastic/integrations/pull/14607 | |
link: https://github.com/elastic/integrations/pull/14974 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes Dashboard Links Panel filter options for multiple integration packages by setting useCurrentFilters
to false
to prevent unwanted filter inheritance when navigating between dashboards.
- Adds standardized options configuration to all dashboard link panels across affected packages
- Replaces markdown-based navigation with proper links panel components for better UX
- Updates version numbers and changelog entries for all modified packages
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
packages/system/manifest.yml | Version bump to 2.5.3 |
packages/system/kibana/dashboard/*.json | Adds filter options to dashboard links and converts navigation from markdown to links panel |
packages/nginx_ingress_controller_otel/manifest.yml | Version bump to 0.2.1 |
packages/nginx_ingress_controller_otel/kibana/dashboard/*.json | Adds filter options to dashboard links |
packages/nginx/manifest.yml | Version bump to 2.3.1 |
packages/nginx/kibana/dashboard/*.json | Adds filter options to dashboard links |
packages/nagios_xi/manifest.yml | Version bump to 1.7.1 |
packages/nagios_xi/kibana/dashboard/*.json | Adds filter options to dashboard links |
packages/iis/manifest.yml | Version bump to 1.24.1 |
packages/iis/kibana/dashboard/*.json | Adds filter options to dashboard links |
packages/*/changelog.yml | Changelog entries documenting the bugfix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
"params": { | ||
"fontSize": 12, | ||
"markdown": "### Navigation\n\n#### System\n\n[Logon Activity](#/dashboard/system-2c4debf0-ef4f-4379-99a1-c57c307f23af) \n[Directory \u0026 Account Monitoring](#/dashboard/system-3c46ecdb-0a41-4be3-907e-722de8edac12) \n[System \u0026 Process Activity](#/dashboard/system-0e70e1bd-9a57-4f17-9d96-cc97e3d3a4f9) \n**Policy \u0026 Object Monitoring**\n\n#### Description\n\nThis dashboard provides focused visibility into policy enforcement and object access activities.\n\nIt showcases the top users, domains, and processes involved in object access attempts, along with access permissions and firewall rule usage. Key visualizations highlight rule modifications, failures, and filtering behaviors. Detailed logs and saved searches offer insights into share access, transaction state changes, and firewall filter changes, helping identify policy violations and strengthen host-level security.\n\n**[Integration Page](/app/integrations/detail/system/overview)**", | ||
"markdown": "This dashboard provides focused visibility into policy enforcement and object access activities.\n\nIt showcases the top users, domains, and processes involved in object access attempts, along with access permissions and firewall rule usage. Key visualizations highlight rule modifications, failures, and filtering behaviors. Detailed logs and saved searches offer insights into share access, transaction state changes, and firewall filter changes, helping identify policy violations and strengthen host-level security.\n\n**[Integration Page](/app/integrations/detail/system/overview)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown text contains an incomplete closing markdown link syntax. It should end with **
instead of \n"
. The line should be: **[Integration Page](/app/integrations/detail/system/overview)**
"markdown": "This dashboard provides focused visibility into policy enforcement and object access activities.\n\nIt showcases the top users, domains, and processes involved in object access attempts, along with access permissions and firewall rule usage. Key visualizations highlight rule modifications, failures, and filtering behaviors. Detailed logs and saved searches offer insights into share access, transaction state changes, and firewall filter changes, helping identify policy violations and strengthen host-level security.\n\n**[Integration Page](/app/integrations/detail/system/overview)\n", | |
"markdown": "This dashboard provides focused visibility into policy enforcement and object access activities.\n\nIt showcases the top users, domains, and processes involved in object access attempts, along with access permissions and firewall rule usage. Key visualizations highlight rule modifications, failures, and filtering behaviors. Detailed logs and saved searches offer insights into share access, transaction state changes, and firewall filter changes, helping identify policy violations and strengthen host-level security.\n\n**[Integration Page](/app/integrations/detail/system/overview)**\n", |
Copilot uses AI. Check for mistakes.
"params": { | ||
"fontSize": 12, | ||
"markdown": "### Navigation\n\n#### System\n\n[Logon Activity](#/dashboard/system-2c4debf0-ef4f-4379-99a1-c57c307f23af) \n**Directory \u0026 Account Monitoring** \n[System \u0026 Process Activity](#/dashboard/system-0e70e1bd-9a57-4f17-9d96-cc97e3d3a4f9) \n[Policy \u0026 Object Monitoring](#/dashboard/system-db94459a-7232-4d1b-aa0c-b80dece8bc3a) \n\n#### Description\nThis dashboard focuses on monitoring directory changes and account activities.\n\nIt highlights top users, domains, and Active Directory objects involved in modifications, along with trends in attribute changes and replication events. Password policy checks are tracked by user, workstation, and domain, with detailed logs providing insight into replication syncs and policy enforcement, helping ensure directory integrity and account security.\n\n\n**[Integration Page](/app/integrations/detail/system/overview)**", | ||
"markdown": "This dashboard focuses on monitoring directory changes and account activities.\n\nIt highlights top users, domains, and Active Directory objects involved in modifications, along with trends in attribute changes and replication events. Password policy checks are tracked by user, workstation, and domain, with detailed logs providing insight into replication syncs and policy enforcement, helping ensure directory integrity and account security.\n\n\n**[Integration Page](/app/integrations/detail/system/overview)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown text contains an incomplete closing markdown link syntax. It should end with **
instead of \n"
. The line should be: **[Integration Page](/app/integrations/detail/system/overview)**
"markdown": "This dashboard focuses on monitoring directory changes and account activities.\n\nIt highlights top users, domains, and Active Directory objects involved in modifications, along with trends in attribute changes and replication events. Password policy checks are tracked by user, workstation, and domain, with detailed logs providing insight into replication syncs and policy enforcement, helping ensure directory integrity and account security.\n\n\n**[Integration Page](/app/integrations/detail/system/overview)\n", | |
"markdown": "This dashboard focuses on monitoring directory changes and account activities.\n\nIt highlights top users, domains, and Active Directory objects involved in modifications, along with trends in attribute changes and replication events. Password policy checks are tracked by user, workstation, and domain, with detailed logs providing insight into replication syncs and policy enforcement, helping ensure directory integrity and account security.\n\n\n**[Integration Page](/app/integrations/detail/system/overview)**\n", |
Copilot uses AI. Check for mistakes.
@@ -439,7 +508,7 @@ | |||
"id": "", | |||
"params": { | |||
"fontSize": 12, | |||
"markdown": "### Navigation\n\n#### System\n\n**Logon Activity** \n[Directory \u0026 Account Monitoring](#/dashboard/system-3c46ecdb-0a41-4be3-907e-722de8edac12) \n[System \u0026 Process Activity](#/dashboard/system-0e70e1bd-9a57-4f17-9d96-cc97e3d3a4f9) \n[Policy \u0026 Object Monitoring](#/dashboard/system-db94459a-7232-4d1b-aa0c-b80dece8bc3a) \n\n#### Description\n\nThis dashboard is designed to provide focused visibility into logon and logoff activities using the Security data stream.\n\nIt highlights the top 10 group membership logons by account name, visualizes group membership events by logon type and user, and presents detailed insights into trust direction filtering. The dashboard also tracks workstation lock events across users, security IDs, and account domains to support monitoring of authentication patterns and identification of unusual behavior.\n\n**[Integration Page](/app/integrations/detail/system/overview)**", | |||
"markdown": "This dashboard is designed to provide focused visibility into logon and logoff activities using the Security data stream.\n\nIt highlights the top 10 group membership logons by account name, visualizes group membership events by logon type and user, and presents detailed insights into trust direction filtering. The dashboard also tracks workstation lock events across users, security IDs, and account domains to support monitoring of authentication patterns and identification of unusual behavior.\n\n**[Integration Page](/app/integrations/detail/system/overview)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown text contains an incomplete closing markdown link syntax. It should end with **
instead of \n"
. The line should be: **[Integration Page](/app/integrations/detail/system/overview)**
"markdown": "This dashboard is designed to provide focused visibility into logon and logoff activities using the Security data stream.\n\nIt highlights the top 10 group membership logons by account name, visualizes group membership events by logon type and user, and presents detailed insights into trust direction filtering. The dashboard also tracks workstation lock events across users, security IDs, and account domains to support monitoring of authentication patterns and identification of unusual behavior.\n\n**[Integration Page](/app/integrations/detail/system/overview)\n", | |
"markdown": "This dashboard is designed to provide focused visibility into logon and logoff activities using the Security data stream.\n\nIt highlights the top 10 group membership logons by account name, visualizes group membership events by logon type and user, and presents detailed insights into trust direction filtering. The dashboard also tracks workstation lock events across users, security IDs, and account domains to support monitoring of authentication patterns and identification of unusual behavior.\n\n**[Integration Page](/app/integrations/detail/system/overview)**\n", |
Copilot uses AI. Check for mistakes.
"params": { | ||
"fontSize": 12, | ||
"markdown": "### Navigation\n\n#### System\n\n[Logon Activity](#/dashboard/system-2c4debf0-ef4f-4379-99a1-c57c307f23af) \n[Directory \u0026 Account Monitoring](#/dashboard/system-3c46ecdb-0a41-4be3-907e-722de8edac12) \n**System \u0026 Process Activity** \n[Policy \u0026 Object Monitoring](#/dashboard/system-db94459a-7232-4d1b-aa0c-b80dece8bc3a)\n\n#### Description\n\nThis dashboard offers visibility into critical system and process activities, with a focus on file and cryptographic operations.\n\nIt highlights key and file operations by provider, top affected file paths, and device connection trends over time. Saved searches provide detailed insights into cryptographic events, key migrations, and file operations, supporting analysis of system behavior and potential security impacts.\n\n\n**[Integration Page](/app/integrations/detail/system/overview)**", | ||
"markdown": "This dashboard offers visibility into critical system and process activities, with a focus on file and cryptographic operations.\n\nIt highlights key and file operations by provider, top affected file paths, and device connection trends over time. Saved searches provide detailed insights into cryptographic events, key migrations, and file operations, supporting analysis of system behavior and potential security impacts.\n\n\n**[Integration Page](/app/integrations/detail/system/overview)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown text contains an incomplete closing markdown link syntax. It should end with **
instead of \n"
. The line should be: **[Integration Page](/app/integrations/detail/system/overview)**
"markdown": "This dashboard offers visibility into critical system and process activities, with a focus on file and cryptographic operations.\n\nIt highlights key and file operations by provider, top affected file paths, and device connection trends over time. Saved searches provide detailed insights into cryptographic events, key migrations, and file operations, supporting analysis of system behavior and potential security impacts.\n\n\n**[Integration Page](/app/integrations/detail/system/overview)\n", | |
"markdown": "This dashboard offers visibility into critical system and process activities, with a focus on file and cryptographic operations.\n\nIt highlights key and file operations by provider, top affected file paths, and device connection trends over time. Saved searches provide detailed insights into cryptographic events, key migrations, and file operations, supporting analysis of system behavior and potential security impacts.\n\n\n**[Integration Page](/app/integrations/detail/system/overview)**\n", |
Copilot uses AI. Check for mistakes.
@Linu-Elias - Can you confirm the latest integration is installed after making the change and link works as expected? |
💚 Build Succeeded
History
cc @Linu-Elias |
|
@muthu-mps, Yes, I tested it by installing and checking that the links are working as expected. Now, only the current dashboard filters are applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package iis - 1.24.1 containing this change is available at https://epr.elastic.co/package/iis/1.24.1/ |
Package nagios_xi - 1.7.1 containing this change is available at https://epr.elastic.co/package/nagios_xi/1.7.1/ |
Package nginx - 2.3.1 containing this change is available at https://epr.elastic.co/package/nginx/2.3.1/ |
Package nginx_ingress_controller_otel - 0.2.1 containing this change is available at https://epr.elastic.co/package/nginx_ingress_controller_otel/0.2.1/ |
Package system - 2.5.3 containing this change is available at https://epr.elastic.co/package/system/2.5.3/ |
Proposed commit message
add panel filter options to all dashboard links
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots