Skip to content

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

Validate if fields from API responses that are used for pagination exists and contain valid data before using them for further requests.

Fixes this error where the from query parameter contains garbage after receiving a response without the next_checkpoint field:

"event":{"error":{"code":"400","id":"400 Bad Request","message":"GET https://<>.portal.vectra.ai/api/v3.4/events/detections: {\"detail\":\"The following query parameter(s) are invalid: 2.966648e+06\"}"}}

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chemamartinez chemamartinez self-assigned this Aug 1, 2025
@chemamartinez chemamartinez added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:vectra_rux Vectra RUX labels Aug 1, 2025
@chemamartinez chemamartinez marked this pull request as ready for review August 1, 2025 14:52
@chemamartinez chemamartinez requested a review from a team as a code owner August 1, 2025 14:52
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Aug 1, 2025
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to leave out the sample_event.json changes. Only IDs, date, and agent version changed (and not to a new minimum agent version).

Otherwise looks good.

Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a README update to get the reverted sample_event.json content.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chemamartinez

Copy link

@chemamartinez chemamartinez merged commit d124b5c into elastic:main Aug 4, 2025
9 checks passed
@chemamartinez chemamartinez deleted the vectra_rux-validate-request-fields branch August 4, 2025 09:40
@elastic-vault-github-plugin-prod

Package vectra_rux - 0.3.1 containing this change is available at https://epr.elastic.co/package/vectra_rux/0.3.1/

@andrewkroh andrewkroh removed the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Aug 4, 2025
robester0403 pushed a commit to robester0403/integrations that referenced this pull request Aug 14, 2025
…c#14772)

Validate if fields from API responses that are used for pagination exists and contain valid data before using them for further requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:vectra_rux Vectra RUX Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants