-
Notifications
You must be signed in to change notification settings - Fork 476
Vectra RUX: validate pagination parameters from API responses #14772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectra RUX: validate pagination parameters from API responses #14772
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to leave out the sample_event.json
changes. Only IDs, date, and agent version changed (and not to a new minimum agent version).
Otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a README update to get the reverted sample_event.json
content.
💚 Build Succeeded
History
|
|
Package vectra_rux - 0.3.1 containing this change is available at https://epr.elastic.co/package/vectra_rux/0.3.1/ |
…c#14772) Validate if fields from API responses that are used for pagination exists and contain valid data before using them for further requests.
Proposed commit message
Validate if fields from API responses that are used for pagination exists and contain valid data before using them for further requests.
Fixes this error where the
from
query parameter contains garbage after receiving a response without thenext_checkpoint
field:Checklist
changelog.yml
file.