-
Notifications
You must be signed in to change notification settings - Fork 476
[AWS] Update README - EC2 Instance IAM Role for AWS Authentication #13434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportTo see the full report comment with |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bturquet Thanks! Should I update |
Hey @ecs-chrisg, yes, we should always add new changes on top of the latest ones first. If we need to support previous stack versions (e.g., 8.15.x), we can backport the change. However, adding it as the latest is fine since this is a pure-docs change. Once merged, these changes will be available at https://www.elastic.co/docs/reference/integrations/aws/ and Kibana versions matching: conditions:
kibana:
version: "~8.16.6 || ~8.17.4 || ^8.18.0 || ^9.0.0" So a user on 8.15 or earlier stack versions will not see the updated docs in Kibana. |
@zmoog Makes sense! Newer versions of the integration keep getting merged to main in the time since this PR was opened, so I have to keep updating this integration's version # to stay up to date. I just updated |
In the
The two accidentally had almost the same values, creating an ambiguity. For example, if we bump the integration |
|
💚 Build Succeeded
History
|
Package aws - 3.3.2 containing this change is available at https://epr.elastic.co/package/aws/3.3.2/ |
…lastic#13434) Update AWS readme - Add a subsection to the AWS Credentials section explaining how to use an EC2 instance's IAM role for AWS authentication.
Proposed commit message
Update AWS readme - Add a subsection to the AWS Credentials section explaining how to use an EC2 instance's IAM role for AWS authentication.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots