Initial release of PingFederate #12113

muskan-agarwal26 · 2024-12-16T11:31:13Z

Proposed commit message

Create New integration package ping_federate.

Added admin and audit data stream.
Added data collection logic for the data streams.
Added the ingest pipeline for the data streams.
Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
Added dashboards and visualizations.
Added pipeline test for the data streams.
Added system test cases for the data streams.

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.
I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Clone integrations repo.
Install elastic package locally.
Start elastic stack using elastic-package.
Move to integrations/packages/ping_federate directory.
Run the following command to run tests.

elastic-package test

elastic-package test
Run asset tests for the package
2024/12/16 16:45:28  INFO License text found in "/root/github/integrations/LICENSE.txt" will be included in package
--- Test results for package: ping_federate - START ---
╭───────────────┬─────────────┬───────────┬────────────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE       │ DATA STREAM │ TEST TYPE │ TEST NAME                                                              │ RESULT │ TIME ELAPSED │
├───────────────┼─────────────┼───────────┼────────────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ ping_federate │             │ asset     │ dashboard ping_federate-4e1a3b90-8da8-4d5d-89e7-5c49fb4a3541 is loaded │ PASS   │      1.538µs │
│ ping_federate │             │ asset     │ dashboard ping_federate-c975ed3a-3c11-4352-830e-84f1efaf9e92 is loaded │ PASS   │        256ns │
│ ping_federate │ admin       │ asset     │ index_template logs-ping_federate.admin is loaded                      │ PASS   │        150ns │
│ ping_federate │ admin       │ asset     │ ingest_pipeline logs-ping_federate.admin-0.1.0 is loaded               │ PASS   │        200ns │
│ ping_federate │ audit       │ asset     │ index_template logs-ping_federate.audit is loaded                      │ PASS   │        214ns │
│ ping_federate │ audit       │ asset     │ ingest_pipeline logs-ping_federate.audit-0.1.0 is loaded               │ PASS   │        214ns │
╰───────────────┴─────────────┴───────────┴────────────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: ping_federate - END   ---
Done
Run pipeline tests for the package
--- Test results for package: ping_federate - START ---
╭───────────────┬─────────────┬───────────┬────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE       │ DATA STREAM │ TEST TYPE │ TEST NAME                                  │ RESULT │ TIME ELAPSED │
├───────────────┼─────────────┼───────────┼────────────────────────────────────────────┼────────┼──────────────┤
│ ping_federate │ admin       │ pipeline  │ (ingest pipeline warnings test-admin.log)  │ PASS   │  557.86265ms │
│ ping_federate │ admin       │ pipeline  │ test-admin.log                             │ PASS   │  214.58294ms │
│ ping_federate │ audit       │ pipeline  │ (ingest pipeline warnings test-audit.json) │ PASS   │ 494.078565ms │
│ ping_federate │ audit       │ pipeline  │ test-audit.json                            │ PASS   │ 210.997341ms │
╰───────────────┴─────────────┴───────────┴────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: ping_federate - END   ---
Done
Run policy tests for the package
--- Test results for package: ping_federate - START ---
No test results
--- Test results for package: ping_federate - END   ---
Done
Run static tests for the package
--- Test results for package: ping_federate - START ---
╭───────────────┬─────────────┬───────────┬──────────────────────────┬────────┬──────────────╮
│ PACKAGE       │ DATA STREAM │ TEST TYPE │ TEST NAME                │ RESULT │ TIME ELAPSED │
├───────────────┼─────────────┼───────────┼──────────────────────────┼────────┼──────────────┤
│ ping_federate │ admin       │ static    │ Verify sample_event.json │ PASS   │ 144.542411ms │
│ ping_federate │ audit       │ static    │ Verify sample_event.json │ PASS   │ 145.240233ms │
╰───────────────┴─────────────┴───────────┴──────────────────────────┴────────┴──────────────╯
--- Test results for package: ping_federate - END   ---
Done
Run system tests for the package
2024/12/16 16:45:37  INFO License text found in "/root/github/integrations/LICENSE.txt" will be included in package
2024/12/16 16:46:36  INFO Write container logs to file: /root/github/integrations/build/container-logs/ping_federate-logfile-admin-1734347796053043713.log
2024/12/16 16:47:30  INFO Write container logs to file: /root/github/integrations/build/container-logs/ping_federate-logfile-audit-1734347850709219074.log
2024/12/16 16:48:30  INFO Write container logs to file: /root/github/integrations/build/container-logs/ping_federate-tcp-audit-1734347910021317050.log
2024/12/16 16:49:27  INFO Write container logs to file: /root/github/integrations/build/container-logs/ping_federate-udp-audit-1734347967879909900.log
2024/12/16 16:50:24  INFO Write container logs to file: /root/github/integrations/build/container-logs/ping_federate-tls-audit-1734348024794769549.log
--- Test results for package: ping_federate - START ---
╭───────────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE       │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├───────────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤
│ ping_federate │ admin       │ system    │ logfile   │ PASS   │   38.8769948s │
│ ping_federate │ audit       │ system    │ logfile   │ PASS   │ 36.327029568s │
│ ping_federate │ audit       │ system    │ tcp       │ PASS   │ 40.646607107s │
│ ping_federate │ audit       │ system    │ tls       │ PASS   │ 39.845334757s │
│ ping_federate │ audit       │ system    │ udp       │ PASS   │ 39.845734973s │
╰───────────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: ping_federate - END   ---
Done

Screenshots

kcreddy · 2024-12-16T11:34:20Z

/test

elasticmachine · 2024-12-16T11:34:33Z

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy · 2024-12-17T06:52:06Z

/test

kcreddy · 2024-12-17T12:18:27Z

/test

elastic-vault-github-plugin-prod · 2024-12-17T12:39:05Z

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

packages/ping_federate/_dev/build/docs/README.md

packages/ping_federate/data_stream/admin/elasticsearch/ingest_pipeline/default.yml

kcreddy · 2024-12-19T09:10:08Z

packages/ping_federate/data_stream/admin/elasticsearch/ingest_pipeline/default.yml

+      value: >-
+        Processor '{{{ _ingest.on_failure_processor_type }}}'
+        {{{#_ingest.on_failure_processor_tag}}}with tag '{{{ _ingest.on_failure_processor_tag }}}'
+        {{{/_ingest.on_failure_processor_tag}}}failed with message '{{{ _ingest.on_failure_message }}}'


Can you append preserve_original_event to tags inside this on_failure clause?
Example PR: https://github.com/elastic/integrations/pull/12046/files

@piyush-elastic , please update your templates (if any) as this change should be for all packages going forward.

packages/ping_federate/data_stream/admin/manifest.yml

packages/ping_federate/data_stream/audit/elasticsearch/ingest_pipeline/default.yml

packages/ping_federate/manifest.yml

kcreddy · 2024-12-19T12:38:39Z

/test

packages/ping_federate/_dev/build/docs/README.md

packages/ping_federate/data_stream/admin/elasticsearch/ingest_pipeline/default.yml

kcreddy · 2024-12-20T11:03:23Z

/test

elasticmachine · 2024-12-20T11:22:31Z

💚 Build Succeeded

Buildkite Build
Commit: c79c6a8ada7a097b2bc7a969bde6306dc94b7934

History

💚 Build #19710 succeeded 8217c7d98d93f03745b877b2aab4615d465b0a55
💚 Build #19605 succeeded 8ee7108f425d085cba0b83eefab2fb28913bc99b
💔 Build #19592 failed 73e82e92eb06c63804a9b712111e41cdeddec006
💚 Build #19542 succeeded 39c08b41373a7ee22ec442425ffdbd5c06dbeae2

elastic-sonarqube · 2024-12-20T11:22:32Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
93.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

elastic-vault-github-plugin-prod · 2024-12-20T12:52:34Z

Package ping_federate - 0.1.0 containing this change is available at https://epr.elastic.co/package/ping_federate/0.1.0/

Create New integration package ping_federate. Added admin and audit data stream. Added data collection logic for the data streams. Added the ingest pipeline for the data streams. Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files. Added dashboards and visualizations. Added pipeline test for the data streams. Added system test cases for the data streams.

kcreddy added Crest Contributions from Crest developement team. Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Dec 16, 2024

kcreddy added the New Integration Issue or pull request for creating a new integration package. label Dec 16, 2024

kcreddy reviewed Dec 19, 2024

View reviewed changes

muskan-agarwal26 requested a review from kcreddy December 19, 2024 12:26

kcreddy reviewed Dec 19, 2024

View reviewed changes

packages/ping_federate/_dev/build/docs/README.md Outdated Show resolved Hide resolved

packages/ping_federate/_dev/build/docs/README.md Outdated Show resolved Hide resolved

packages/ping_federate/data_stream/admin/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved

muskan-agarwal26 requested a review from kcreddy December 20, 2024 10:47

kcreddy approved these changes Dec 20, 2024

View reviewed changes

kcreddy merged commit 1c5d4fd into elastic:main Dec 20, 2024
5 checks passed

cpascale43 mentioned this pull request Jan 30, 2025

Ping Identity | PingFederate #1088

Closed

15 tasks

kcreddy mentioned this pull request Feb 5, 2025

Timezone offset is not working for the custom date formats elastic/beats#42133

Open

muskan-agarwal26 deleted the ping_federate-0.1.0 branch February 10, 2025 07:03

Initial release of PingFederate #12113

Initial release of PingFederate #12113

Uh oh!

Conversation

muskan-agarwal26 commented Dec 16, 2024

Proposed commit message

Checklist

How to test this PR locally

Screenshots

Uh oh!

kcreddy commented Dec 16, 2024

Uh oh!

elasticmachine commented Dec 16, 2024

Uh oh!

kcreddy commented Dec 17, 2024

Uh oh!

kcreddy commented Dec 17, 2024

Uh oh!

elastic-vault-github-plugin-prod bot commented Dec 17, 2024

🚀 Benchmarks report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kcreddy Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kcreddy commented Dec 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kcreddy commented Dec 20, 2024

Uh oh!

elasticmachine commented Dec 20, 2024

💚 Build Succeeded

History

Uh oh!

elastic-sonarqube bot commented Dec 20, 2024

Quality Gate passed

Uh oh!

Uh oh!

elastic-vault-github-plugin-prod bot commented Dec 20, 2024

Uh oh!

Uh oh!