Skip to content

Conversation

chemamartinez
Copy link
Contributor

@chemamartinez chemamartinez commented Nov 22, 2024

Proposed commit message

Adding a fingerprint processor for the threat_attributes data stream to avoid ingesting the same indicators every time a request to the API is made.

Updated the fingerprint for the threat data stream, by including created/updated timestamps, so subsequent updates of the indicators are also ingested.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chemamartinez chemamartinez added Integration:ti_misp MISP bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Nov 22, 2024
@chemamartinez chemamartinez self-assigned this Nov 22, 2024
@chemamartinez chemamartinez marked this pull request as ready for review November 22, 2024 08:35
@chemamartinez chemamartinez requested a review from a team as a code owner November 22, 2024 08:35
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @chemamartinez

Copy link

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a nit. Change thread to threat in the PR description.

@chemamartinez chemamartinez merged commit 79ec43e into elastic:main Nov 22, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package ti_misp - 1.35.8 containing this change is available at https://epr.elastic.co/package/ti_misp/1.35.8/

qcorporation pushed a commit that referenced this pull request Feb 3, 2025
Adding a fingerprint processor for the threat_attributes data stream to avoid ingesting the same indicators every time a request to the API is made.

Updated the fingerprint for the threat data stream, by including created/updated timestamps, so subsequent updates of the indicators are also ingested.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
Adding a fingerprint processor for the threat_attributes data stream to avoid ingesting the same indicators every time a request to the API is made.

Updated the fingerprint for the threat data stream, by including created/updated timestamps, so subsequent updates of the indicators are also ingested.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
Adding a fingerprint processor for the threat_attributes data stream to avoid ingesting the same indicators every time a request to the API is made.

Updated the fingerprint for the threat data stream, by including created/updated timestamps, so subsequent updates of the indicators are also ingested.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Adding a fingerprint processor for the threat_attributes data stream to avoid ingesting the same indicators every time a request to the API is made.

Updated the fingerprint for the threat data stream, by including created/updated timestamps, so subsequent updates of the indicators are also ingested.
@chemamartinez chemamartinez deleted the ti_misp-fix-fingerprint branch February 6, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:ti_misp MISP Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants