-
Notifications
You must be signed in to change notification settings - Fork 476
[azure] rename azure.platformlogs.properties as .raw when it contains a string value #11732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zmoog
merged 0 commits into
elastic:main
from
zmoog:zmoog/azure-logs-platformlogs-fallback-as-raw
Nov 14, 2024
Merged
[azure] rename azure.platformlogs.properties as .raw when it contains a string value #11732
zmoog
merged 0 commits into
elastic:main
from
zmoog:zmoog/azure-logs-platformlogs-fallback-as-raw
Nov 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
platformlogs |
5649.72 | 4651.16 | -998.56 (-17.67%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
💚 Build Succeeded
cc @zmoog |
kaiyan-sheng
approved these changes
Nov 13, 2024
ishleenk17
approved these changes
Nov 14, 2024
Package azure - 1.19.2 containing this change is available at https://epr.elastic.co/package/azure/1.19.2/ |
5 tasks
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
… a string value (elastic#11732) Mitigates elastic#11729 If the `azure.platformlogs.properties` field contains a string instead of the expected object, the pipeline renames it as `azure.platformlogs.properties.raw` field. This allows: - Elasticsearch to index the log events instead of dropping them (status 400) - Users to customize parsing of the `.raw` field in the `logs-azure.platformlogs@custom pipeline` This avoids dropping log events while we build a complete and more robust [invalid JSON](elastic#11729) handling solution with elastic#11728
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
… a string value (elastic#11732) Mitigates elastic#11729 If the `azure.platformlogs.properties` field contains a string instead of the expected object, the pipeline renames it as `azure.platformlogs.properties.raw` field. This allows: - Elasticsearch to index the log events instead of dropping them (status 400) - Users to customize parsing of the `.raw` field in the `logs-azure.platformlogs@custom pipeline` This avoids dropping log events while we build a complete and more robust [invalid JSON](elastic#11729) handling solution with elastic#11728
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Pull request that fixes a bug issue
Integration:azure
Azure Logs
Team:obs-ds-hosted-services
Observability Hosted Services team [elastic/obs-ds-hosted-services]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Mitigates #11729
If the
azure.platformlogs.properties
field contains a string instead of the expected object, the pipeline renames it asazure.platformlogs.properties.raw
field.This allows:
.raw
field in thelogs-azure.platformlogs@custom pipeline
This avoids dropping log events while we build a complete and more robust invalid JSON handling solution with #11728
Checklist
changelog.yml
file.I have verified that any added dashboard complies with Kibana's Dashboard good practicesRelated issues