Skip to content

Conversation

dwhyrock
Copy link
Contributor

@dwhyrock dwhyrock commented Oct 9, 2024

Proposed commit message

Some of the AAA log messages can have hostnames for the server = field. This loosens up the grok pattern to use IPORHOST instead of just IP.

This also adds a new pattern to allow for an unhandled ICMP message with a value of <unknown> for the Original IP payload value.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@dwhyrock dwhyrock requested a review from a team as a code owner October 9, 2024 13:44
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:cisco_asa Cisco ASA Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Oct 9, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@gogochan gogochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - merge conflict.

Copy link
Contributor

@jrmolin jrmolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Also looks like the example data is generic enough. Are those the correct numbers? 113004, 113005, 313005? Mostly the 313005. It probably is. I could look it up, but I'm just going to talk to myself in this little box here. It looks good.

@dwhyrock
Copy link
Contributor Author

Are those the correct numbers? 113004, 113005, 313005? Mostly the 313005. It probably is. I could look it up, but I'm just going to talk to myself in this little box here. It looks good.

Those numbers were from actual logs. I only changed the IPs/Hostnames to be generic, but left those values alone.

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

@dwhyrock dwhyrock merged commit 5dc9792 into elastic:main Oct 10, 2024
5 checks passed
@dwhyrock dwhyrock deleted the cisco-asa-use-iporhost branch October 10, 2024 15:58
@elastic-vault-github-plugin-prod

Package cisco_asa - 2.38.1 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…stic#11378)

* Adding new logs and fixes

* Adding new expected logs, as well as changelog and manifest updates
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…stic#11378)

* Adding new logs and fixes

* Adding new expected logs, as well as changelog and manifest updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cisco_asa Cisco ASA Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants