-
Notifications
You must be signed in to change notification settings - Fork 476
graphactivitylogs: Fix client|source.geo.location mapping #11102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphactivitylogs: Fix client|source.geo.location mapping #11102
Conversation
According to the Client Fields and Source Fields ECS reference, we should map However, the - name: client.geo.location.lat
external: ecs
- name: client.geo.location.lon
external: ecs
- name: source.geo.location.lat
external: ecs
- name: source.geo.location.lon
external: ecs That causes Elasticsearch to map the We should probably change the mapping to: - name: client.geo.location
external: ecs
- name: source.geo.location
external: ecs To align these fields with ECS and produce the expected @kcreddy, are there specific reasons to use the |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
provisioning |
3225.81 | 2398.08 | -827.73 (-25.66%) | 💔 |
To see the full report comment with /test benchmark fullreport
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a changelog and manifest update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code owner approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcreddy, are there specific reasons to use the
*.lat|.lon
mapping?
I don't see one. Must be a miss from previous datastreams which missed this fix.
Thanks for fixing 👍🏼
packages/azure/changelog.yml
Outdated
- version: "1.14.1" | ||
changes: | ||
- description: Fix [client|source].geo.location ECS field mapping | ||
type: enhancement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You labeled the PR as a bug and the patch version was incremented so all signals suggest this should be type: bugfix
instead of enhancement. Can you confirm the intention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Andrew, thanks for the heads up. This is a bug; updating the changelog classification accordingly.
💚 Build Succeeded
History
cc @zmoog |
|
) Align `client|source.geo.location` fields to ECS mapping. Users reported mapping exceptions due to Elasticsearch mapping the `client|source.geo.location` fields as `object` instead of `geo_point`. See elastic#10848 for more.
) Align `client|source.geo.location` fields to ECS mapping. Users reported mapping exceptions due to Elasticsearch mapping the `client|source.geo.location` fields as `object` instead of `geo_point`. See elastic#10848 for more.
Proposed commit message
Align
client|source.geo.location
fields to ECS mapping.Users reported mapping exceptions due to Elasticsearch mapping the
client|source.geo.location
fields asobject
instead ofgeo_point
. See #10848 for more.Checklist
changelog.yml
file.Related issues