Skip to content

[system][diskio]: update system.diskio as it requires root privileges #10512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2024
Merged

[system][diskio]: update system.diskio as it requires root privileges #10512

merged 5 commits into from
Jul 24, 2024

Conversation

VihasMakwana
Copy link
Contributor

  • Enhancement

Proposed commit message

Update system.diskio integration as it requires root privileges.
See elastic/elastic-agent#4982

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@VihasMakwana VihasMakwana requested a review from a team as a code owner July 16, 2024 17:52
@VihasMakwana VihasMakwana marked this pull request as draft July 16, 2024 17:52
@VihasMakwana VihasMakwana changed the title [system][diskio]: update system.diskio as it requires root privileges DRAFT [system][diskio]: update system.diskio as it requires root privileges Jul 16, 2024
@elasticmachine
Copy link

elasticmachine commented Jul 16, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@VihasMakwana VihasMakwana marked this pull request as ready for review July 19, 2024 13:06
@VihasMakwana VihasMakwana requested review from a team as code owners July 19, 2024 13:06
@VihasMakwana VihasMakwana changed the title DRAFT [system][diskio]: update system.diskio as it requires root privileges [system][diskio]: update system.diskio as it requires root privileges Jul 19, 2024
@andrewkroh andrewkroh added Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 19, 2024
@jlind23
Copy link
Contributor

jlind23 commented Jul 24, 2024

buildkite test it

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
11.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@VihasMakwana VihasMakwana merged commit 9b197da into main Jul 24, 2024
5 checks passed
@elasticmachine
Copy link

Package system - 1.59.4 containing this change is available at https://epr.elastic.co/search?package=system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@nfritts nfritts nfritts approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees
No one assigned
Labels
Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] - system.diskio datastream missing on Kibana for unprivileged mode.
6 participants
@VihasMakwana @elasticmachine @jlind23 @nfritts @ishleenk17 @andrewkroh