Fix CI #84
Merged
Fix CI #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
force-pushed
the
remove-xfail
branch
2 times, most recently
from
6efb151 to
300296e
Compare
pquentin
force-pushed
the
remove-xfail
branch
from
300296e to
c2d0067
Compare
miguelgrinberg
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
So most errors fixed themselves at some point. However,
test_ignore_error_if_raisedbecame flaky. I think there was a race where either 42 or "c" could win. And if "c" won, then 42 was coerced into a string, which meant the test did not fail as expected. Adding an explicit mapping fixed this. I also added notifications to be alerted of failure.