-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ES|QL query builder integration with the DSL module #3048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,031
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Preview links for changed docs |
74a3788
to
89f9131
Compare
3548a7c
to
124fa31
Compare
124fa31
to
5495f82
Compare
pquentin
approved these changes
Sep 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM, except the multi_match change.
miguelgrinberg
added a commit
that referenced
this pull request
Sep 3, 2025
This change was reviewed when it was part of #3048.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-3048-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 228e66c702f06e2d8b4e33d77131c0f21c6b34d2
# Push it to GitHub
git push --set-upstream origin backport-3048-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19 Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
* ES|QL query builder integration with the DSL module * esql DSL tests * more esql DSL tests * documentation * add esql+dsl example * review feedback (cherry picked from commit 228e66c)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
* ES|QL query builder integration with the DSL module * esql DSL tests * more esql DSL tests * documentation * add esql+dsl example * review feedback (cherry picked from commit 228e66c)
miguelgrinberg
added a commit
that referenced
this pull request
Sep 3, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Sep 3, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Sep 3, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Sep 3, 2025
* ES|QL query builder integration with the DSL module * esql DSL tests * more esql DSL tests * documentation * add esql+dsl example * review feedback (cherry picked from commit 228e66c) Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg
added a commit
that referenced
this pull request
Sep 3, 2025
…3056) * ES|QL query builder integration with the DSL module (#3048) * ES|QL query builder integration with the DSL module * esql DSL tests * more esql DSL tests * documentation * add esql+dsl example * review feedback (cherry picked from commit 228e66c) * python 3.8 typing fix --------- Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg
added a commit
to miguelgrinberg/elasticsearch-py
that referenced
this pull request
Sep 3, 2025
…lastic#3056) * ES|QL query builder integration with the DSL module (elastic#3048) * ES|QL query builder integration with the DSL module * esql DSL tests * more esql DSL tests * documentation * add esql+dsl example * review feedback (cherry picked from commit 228e66c) * python 3.8 typing fix --------- Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg
added a commit
that referenced
this pull request
Sep 4, 2025
…ixes #3056) (#3058) * [Backport 8.19] ES|QL query builder integration with the DSL module (#3056) * ES|QL query builder integration with the DSL module (#3048) * ES|QL query builder integration with the DSL module * esql DSL tests * more esql DSL tests * documentation * add esql+dsl example * review feedback (cherry picked from commit 228e66c) * python 3.8 typing fix --------- Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com> * added missing asciidoc file --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a small integration of the ES|QL query builder with the DSL's
Document
class. It consists of two class methods,Document.esql_from()
andDocument.esql_execute()
. Included are docs updates and a new DSL example that uses this new feature.