Skip to content

Conversation

miguelgrinberg
Copy link
Contributor

@miguelgrinberg miguelgrinberg commented Aug 22, 2025

This change adds a small integration of the ES|QL query builder with the DSL's Document class. It consists of two class methods, Document.esql_from() and Document.esql_execute(). Included are docs updates and a new DSL example that uses this new feature.

Copy link

github-actions bot commented Aug 27, 2025

@miguelgrinberg miguelgrinberg force-pushed the dsl-esql branch 2 times, most recently from 74a3788 to 89f9131 Compare August 29, 2025 09:33
@miguelgrinberg miguelgrinberg marked this pull request as ready for review August 29, 2025 09:33
@miguelgrinberg miguelgrinberg force-pushed the dsl-esql branch 2 times, most recently from 3548a7c to 124fa31 Compare August 29, 2025 09:45
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, except the multi_match change.

miguelgrinberg added a commit that referenced this pull request Sep 3, 2025
This change was reviewed when it was part of #3048.
github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
This change was reviewed when it was part of #3048.

(cherry picked from commit cece9a7)
github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
This change was reviewed when it was part of #3048.

(cherry picked from commit cece9a7)
github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
This change was reviewed when it was part of #3048.

(cherry picked from commit cece9a7)
@miguelgrinberg miguelgrinberg merged commit 228e66c into elastic:main Sep 3, 2025
18 checks passed
@miguelgrinberg miguelgrinberg deleted the dsl-esql branch September 3, 2025 15:40
Copy link

github-actions bot commented Sep 3, 2025

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-3048-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 228e66c702f06e2d8b4e33d77131c0f21c6b34d2
# Push it to GitHub
git push --set-upstream origin backport-3048-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-3048-to-8.19.

github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
* ES|QL query builder integration with the DSL module

* esql DSL tests

* more esql DSL tests

* documentation

* add esql+dsl example

* review feedback

(cherry picked from commit 228e66c)
github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
* ES|QL query builder integration with the DSL module

* esql DSL tests

* more esql DSL tests

* documentation

* add esql+dsl example

* review feedback

(cherry picked from commit 228e66c)
miguelgrinberg added a commit that referenced this pull request Sep 3, 2025
This change was reviewed when it was part of #3048.

(cherry picked from commit cece9a7)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg added a commit that referenced this pull request Sep 3, 2025
This change was reviewed when it was part of #3048.

(cherry picked from commit cece9a7)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg added a commit that referenced this pull request Sep 3, 2025
This change was reviewed when it was part of #3048.

(cherry picked from commit cece9a7)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg added a commit that referenced this pull request Sep 3, 2025
* ES|QL query builder integration with the DSL module

* esql DSL tests

* more esql DSL tests

* documentation

* add esql+dsl example

* review feedback

(cherry picked from commit 228e66c)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg added a commit that referenced this pull request Sep 3, 2025
…3056)

* ES|QL query builder integration with the DSL module (#3048)

* ES|QL query builder integration with the DSL module

* esql DSL tests

* more esql DSL tests

* documentation

* add esql+dsl example

* review feedback

(cherry picked from commit 228e66c)

* python 3.8 typing fix

---------

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg added a commit to miguelgrinberg/elasticsearch-py that referenced this pull request Sep 3, 2025
…lastic#3056)

* ES|QL query builder integration with the DSL module (elastic#3048)

* ES|QL query builder integration with the DSL module

* esql DSL tests

* more esql DSL tests

* documentation

* add esql+dsl example

* review feedback

(cherry picked from commit 228e66c)

* python 3.8 typing fix

---------

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg added a commit that referenced this pull request Sep 4, 2025
…ixes #3056) (#3058)

* [Backport 8.19] ES|QL query builder integration with the DSL module (#3056)

* ES|QL query builder integration with the DSL module (#3048)

* ES|QL query builder integration with the DSL module

* esql DSL tests

* more esql DSL tests

* documentation

* add esql+dsl example

* review feedback

(cherry picked from commit 228e66c)

* python 3.8 typing fix

---------

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>

* added missing asciidoc file

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants