Skip to content

Allow nested aggregation to accept an Aggregation instance. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow nested aggregation to accept an Aggregation instance. #20

wants to merge 1 commit into from

Conversation

picandocodigo
Copy link
Member

Transferred from elastic/elasticsearch-ruby#1251, original PR by @ajjahn

Original Pull Request message

For example:

nested = Aggregation.new do
  sum field: 'foo'
end

outer = Aggregation.new do
  aggregation(:nested_agg, nested)
end

This matches the behavior of the top level query aggregation method.

@ajjahn @picandocodigo
Allow nested aggregation to accept an Aggregation instance.
48274b6 
For example:
```ruby
nested = Aggregation.new do
  sum field: 'foo'
end

outer = Aggregation.new do
  aggregation(:nested_agg, nested)
end
```

This matches the behavior of the top level query `aggregation` method.
@picandocodigo picandocodigo mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picandocodigo @ajjahn