Skip to content

feat: use pre-built fpm container image #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amannocci merged 22 commits into from
Apr 18, 2024
Merged

feat: use pre-built fpm container image #1145

amannocci merged 22 commits into from
Apr 18, 2024

Conversation

@amannocci
Copy link
Contributor

@amannocci amannocci commented Apr 2, 2024

What is the change being made?

  • Use a pre-built fpm container image.

Why is the change being made?

  • Improve build stability of package while maintaining an up-to-date version at oblt robots level.

@amannocci
feat: use pre-built fpm container image
be86751 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci amannocci requested a review from a team April 2, 2024 12:51
@amannocci amannocci self-assigned this Apr 2, 2024
@amannocci
fix: docker login before build phase
32062ce 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
reakaleek
reakaleek previously approved these changes Apr 2, 2024
View reviewed changes
@amannocci
ci: inherit secrets from upstream workflow
66dfb1b 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
amannocci added 5 commits April 2, 2024 15:49
@amannocci
ci(fix): docker login for test packages too
2898017 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
feat: build container image in the project itself
8c829a8 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
ci: enable cache build on push for testing purpose
1e50fac 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
chore: push only latest
15752c7 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
fix: correct container tags
f778992 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
reakaleek
reakaleek previously approved these changes Apr 8, 2024
View reviewed changes
@amannocci
ci: switch to github packages
7466811 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
amannocci added 3 commits April 8, 2024 17:30
@amannocci
ci: disable push publish
a39f537 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
fix: correct permissions
c200fe9 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
fix: correct permissions
394a2ec 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
v1v
v1v reviewed Apr 9, 2024
View reviewed changes
amannocci added 3 commits April 9, 2024 11:12
@amannocci
ci: add version in comments
714919b 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
ci: use hardcode literal when useful
88fb015 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
ci: use a less specific tag
c08f438 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
reakaleek
reakaleek previously approved these changes Apr 10, 2024
View reviewed changes
@amannocci
ci: test package before publishing the container image
273526f 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
ci: re-enable cache on push
c59f5b4 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
ci: forward test image tag
843dd99 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
fix: forward correctly image tag
e637253 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
fix: push to env instead of output
7569906 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
fix: tag correctly test container image
07d53c7 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
ci: cleanup
1f8508c 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci amannocci requested a review from v1v April 17, 2024 16:01
v1v
v1v reviewed Apr 17, 2024
View reviewed changes
v1v
v1v approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amannocci amannocci merged commit 627a3db into main Apr 18, 2024
@amannocci amannocci deleted the feat/use-pre-built-fpm-image branch April 18, 2024 10:17
v1v added a commit that referenced this pull request Apr 26, 2024
@v1v
Merge remote-tracking branch 'upstream/main' into feature/provenance
f46383d 
* upstream/main:
  feat: use pre-built fpm container image (#1145)
  ci(fix): use docker compose v2 instead of v1 (#1146)
  security: add permissions block to workflows (#1136)
  fix: use latest fpm version (#1144)
@v1v v1v mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v1v v1v v1v approved these changes

+1 more reviewer

@reakaleek reakaleek reakaleek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@amannocci amannocci

Labels

agent-php

Projects

APM-Agents (OLD)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amannocci @v1v @reakaleek