-
Notifications
You must be signed in to change notification settings - Fork 377
fixed flaky test in testDisabledModule() #5768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansupol
approved these changes
Nov 14, 2024
senivam
approved these changes
Nov 15, 2024
1 task
This was referenced Dec 21, 2024
This was referenced Jan 8, 2025
Closed
1 task
1 task
1 task
1 task
This was referenced Feb 3, 2025
Closed
Closed
Closed
Closed
Closed
1 task
This was referenced May 26, 2025
This was referenced Jun 4, 2025
1 task
This was referenced Oct 5, 2025
This was referenced Oct 12, 2025
1 task
1 task
This was referenced Nov 18, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of the objects in response string returned by
target("entity/simple").request().get(String.class)isn't guaranteed to be consistent, returning<{"value":"World","name":"Hello"}>instead of<{"name":"Hello","value":"World"}>. The test casetestDisabledModule()fails if this happens.This PR proposes to convert the response and expected strings into Lists, which are then sorted, so that the order assumptions (in this PR, alphabetical order) in the test cases are correct.
This change was confirmed by running the NonDex tool, which explores and reports errors in different behaviors of under-determined Java APIs.
To reproduce this problem, you can run the test with NonDex using these commands:
Here are screenshots of the output produced by NonDex before and after the fix:
Please let me know if you want to discuss these changes.