Skip to content

Conversation

@yanchai2025
Copy link
Contributor

@yanchai2025 yanchai2025 commented Aug 19, 2025

Motivation

This pull request introduces a new pattern builder for masking JSON bodies, updates the documentation to reflect the available pattern builders, and adds comprehensive tests for the new functionality. The main goal is to enhance support for masking sensitive data in JSON objects by providing a dedicated builder and ensuring its correctness.

Proposed Changes

  • Added JsonBodyPatternBuilder class to provide regex-based masking for JSON bodies, supporting cases like masking entire nested objects (e.g., credit card numbers).
  • Updated the README.md to include links to all available pattern builders, including the new JsonBodyPatternBuilder and others, with direct references to their source files.

Test Plan

Added JsonBodyPatternBuilderTest to do the test.

@yanchai2025 yanchai2025 reopened this Aug 19, 2025
@prasanthkv prasanthkv requested a review from Copilot August 20, 2025 17:46
prasanthkv
prasanthkv previously approved these changes Aug 20, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new JSON body pattern builder for masking entire nested JSON objects (e.g., credit card numbers), enhances the documentation with comprehensive links to all available pattern builders, and bumps the project version.

  • Added JsonBodyPatternBuilder class with regex-based masking for JSON nested objects
  • Updated README.md to replace the old bullet list with hyperlinked pattern builder references
  • Incremented version from 2.0.1 to 2.0.2 in pom.xml

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
pom.xml Version bump from 2.0.1 to 2.0.2
JsonBodyPatternBuilderTest.java Comprehensive test suite for the new JsonBodyPatternBuilder with various JSON formatting scenarios
JsonBodyPatternBuilder.java New pattern builder implementation for masking entire JSON object values
README.md Updated documentation with hyperlinked references to all available pattern builders

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@prasanthkv prasanthkv merged commit 0fe9002 into eBay:master Aug 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants