[NetAdapterRename] Allow rename with HyperV Device Naming#523
Closed
nyanhp wants to merge 3 commits intodsccommunity:mainfrom
nyanhp:devnamhv
Closed
[NetAdapterRename] Allow rename with HyperV Device Naming#523nyanhp wants to merge 3 commits intodsccommunity:mainfrom nyanhp:devnamhv
nyanhp wants to merge 3 commits intodsccommunity:mainfrom
nyanhp:devnamhv
Conversation
Contributor
Author
|
Pipeline fails due to dsccommunity/DscResource.DocGenerator#131 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
===================================
Coverage 97% 97%
===================================
Files 28 28
Lines 2078 2081 +3
===================================
+ Hits 2028 2031 +3
Misses 50 50
🚀 New features to boost your workflow:
|
Member
9 tasks
Member
|
This PR can be rebased now. |
Member
|
Hi @nyanhp - Reminder to rebase this PR so we can review. |
Member
|
It was just the changelog that had conflicts so I fixed that so it can be reviewed. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
On Hyper-V VMs, if Device Naming is configured, an advanced property is present that can be used to filter for
a NetAdapter renaming.
This Pull Request (PR) fixes the following issues
None
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is