Skip to content

Minor code style cleanups#496

Merged
PlagueHO merged 3 commits intodsccommunity:mainfrom
gaelicWizard:StyleCleanup
May 23, 2021
Merged

Minor code style cleanups#496
PlagueHO merged 3 commits intodsccommunity:mainfrom
gaelicWizard:StyleCleanup

Conversation

@gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented May 20, 2021

Pull Request (PR) description

This is just a few style cleanups so that resources more closely match code style in other resources. For example, having parameters to Get-NetAdapter be on separate lines instead of all together, extra newlines, &c.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #496 (0572312) into main (983c54b) will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #496   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        28     28           
  Lines      2070   2070           
===================================
  Hits       2021   2021           
  Misses       49     49           
Impacted Files Coverage Δ
...C_DnsConnectionSuffix/DSC_DnsConnectionSuffix.psm1 100% <100%> (ø)
...urces/DSC_FirewallProfile/DSC_FirewallProfile.psm1 100% <100%> (ø)
...urce/DSCResources/DSC_IPAddress/DSC_IPAddress.psm1 99% <100%> (ø)
...urces/DSC_IPAddressOption/DSC_IPAddressOption.psm1 100% <100%> (ø)
...Resources/DSC_NetAdapterLso/DSC_NetAdapterLso.psm1 100% <100%> (ø)
...sources/DSC_NetAdapterName/DSC_NetAdapterName.psm1 100% <100%> (ø)
...sources/DSC_NetAdapterRdma/DSC_NetAdapterRdma.psm1 100% <100%> (ø)
...Resources/DSC_NetAdapterRsc/DSC_NetAdapterRsc.psm1 100% <100%> (ø)
...Resources/DSC_NetAdapterRss/DSC_NetAdapterRss.psm1 100% <100%> (ø)
...urces/DSC_NetAdapterState/DSC_NetAdapterState.psm1 100% <100%> (ø)
... and 7 more

@gaelicWizard gaelicWizard marked this pull request as ready for review May 20, 2021 03:06
@PlagueHO PlagueHO added the needs review The pull request needs a code review. label May 21, 2021
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, 18 of 18 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gaelicWizard)

@PlagueHO PlagueHO merged commit c17520c into dsccommunity:main May 23, 2021
@gaelicWizard gaelicWizard deleted the StyleCleanup branch May 24, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review The pull request needs a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments