Adding spec for error mapper #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swilgosz
reviewed
Apr 1, 2019
spec/error_mapper_spec.rb
Outdated
|
|
||
| describe '.mapped_errors' do | ||
| it 'returns all the current mapped errors' do | ||
| expect(subject.mapped_errors).to eq({}) |
Member
There was a problem hiding this comment.
You set class_variable few lines above, before every single test example, so you don't check how it'll behave without that before block.
Contributor
Author
There was a problem hiding this comment.
@swilgosz the before block will be redundant in case I already add the initialization for @@mapped_errors in ErrorMapper class.
If there is no initialization for @@mapped_errors, and I try to check how it behaves without before block, it will raise uninitialized class variable @@mapped_errors in JsonapiErrorsHandler::ErrorMapper error.
To fix this, I will remove the before block and just keep the initialization for @@mapped_errors. How do you think?
swilgosz
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has solved a part of #1 which is 2. ErrorMapper spec