Fix nullability error CS8620 in tests#12475
Merged
ViktorHofer merged 2 commits intodotnet:mainfrom Nov 13, 2024
Merged
Conversation
Member
Author
|
cc @ViktorHofer |
ViktorHofer
approved these changes
Nov 13, 2024
Member
Author
|
Basically it expects either both operands of Contains be |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12475 +/- ##
===================================================
+ Coverage 75.71428% 75.73518% +0.02089%
===================================================
Files 3152 3153 +1
Lines 635711 635797 +86
Branches 46970 46973 +3
===================================================
+ Hits 481324 481522 +198
+ Misses 150944 150841 -103
+ Partials 3443 3434 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix warning (as error):
This is to unblock dotnet/sdk#44843. I have tested with
10.0.100-alpha.1.24562.4in global.json, this is the only instance of the error.Microsoft Reviewers: Open in CodeFlow