Make Testhost packable except in source-only#46480
Merged
mmitche merged 2 commits intodotnet:mainfrom Feb 4, 2025
Merged
Conversation
ghost
added
Member
Author
|
May have issues with this, verifying. |
NikolaMilosavljevic
approved these changes
Feb 3, 2025
jkoritzinsky
reviewed
Feb 3, 2025
| @@ -5,7 +5,7 @@ | ||
|
|
||
| <PropertyGroup> | ||
| <!-- Don't produce this package when building from source or inside the VMR as it doesn't build correctly on non-Windows. --> |
Member
There was a problem hiding this comment.
Update this comment when sending the PR to VSTest?
Member
Author
There was a problem hiding this comment.
Ya I will if the test here succeeds.
Member
Author
Member
|
VMR and source-only builds are green. Failures are unrelated to this change. Can this be merged? |
Member
|
@mmitche can this be merged now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.