Skip to content

msbuild patch to remove BuildXL feed#44199

Merged
mthalman merged 1 commit intodotnet:release/9.0.1xxfrom
mthalman:buildxl-9.0
Oct 15, 2024
Merged

msbuild patch to remove BuildXL feed#44199
mthalman merged 1 commit intodotnet:release/9.0.1xxfrom
mthalman:buildxl-9.0

Conversation

@mthalman
Copy link
Member

Backport of #44194

@mthalman mthalman requested review from a team as code owners October 15, 2024 19:28
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Oct 15, 2024
Date: Tue, 15 Oct 2024 14:24:55 -0500
Subject: [PATCH] Remove BuildXL feed

Backport: https://github.com/dotnet/msbuild/pull/10765
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've already responded at dotnet/msbuild#10765 (comment) that this needs to be backported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we source build only 1xx versions? Is 8.0.1xx enough (so backporting to 17.8 https://learn.microsoft.com/en-us/dotnet/core/porting/versioning-sdk-msbuild-vs#versioning)? Or do we need it in all 8.0 versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the 1xx versions should be sufficient.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @dotnet/kitten

@mthalman mthalman disabled auto-merge October 15, 2024 21:09
@mthalman mthalman merged commit 75d8977 into dotnet:release/9.0.1xx Oct 15, 2024
@mthalman mthalman deleted the buildxl-9.0 branch October 15, 2024 21:09
marcpopMSFT added a commit that referenced this pull request Oct 18, 2024
panesofglass added a commit to fsprojects/FSharp.Data.JsonSchema that referenced this pull request Feb 6, 2026
…ility

Fixes NETSDK1085 error: "The 'NoBuild' property was set to true
but the 'Build' target was invoked."

This is a known issue with .NET SDK 10.0.102 and multi-targeted
projects. Removing --no-build from the pack command is the
recommended workaround. Pack will still reuse existing build
artifacts from the Build step, so this doesn't cause unnecessary
rebuilds.

See: dotnet/sdk#44199

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants