Skip to content

Install workload manifests in sdk band version derived from the #81461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lewing merged 2 commits into from
Feb 2, 2023
Merged

Install workload manifests in sdk band version derived from the #81461

lewing merged 2 commits into from
Feb 2, 2023

Conversation

@radical
Copy link
Member

@radical radical commented Feb 1, 2023

.. installer version.

  • This is only for running Wasm.Build.Tests

Two new properties are added:

  • SdkBandVersionForWorkload_ComputedFromInstaller: this is based on the version derived from dotnet --version. 8.0.0-alpha.1.1234.1 becomes 8.0.0-alpha.1, and is used as the path where the manifests get installed for testing: sdk-manifests/$(SdkBandVersionForWorkload_ComputedFromInstaller)

  • SdkBandVersionForWorkload_FromRuntimeVersions: this is the version band used for the packages generated. And simply rename of the earlier $(SdkBandVersionForWorkload).

@radical
Install workload manifests in sdk band version derived from the
ff3bcf9 
.. installer version.

- This is only for running Wasm.Build.Tests

Two new properties are added:

- `SdkBandVersionForWorkload_ComputedFromInstaller`: this is based on the
version derived from `dotnet --version`. `8.0.0-alpha.1.1234.1` becomes
`8.0.0-alpha.1`, and is used as the path where the manifests get installed for testing:
`sdk-manifests/$(SdkBandVersionForWorkload_ComputedFromInstaller)`

- `SdkBandVersionForWorkload_FromRuntimeVersions`: this is the version
band used for the packages generated. And simply rename of the earlier
`$(SdkBandVersionForWorkload)`.
@radical radical added arch-wasm WebAssembly architecture test-enhancement Improvements of test source code labels Feb 1, 2023
@radical radical requested a review from steveisok February 1, 2023 06:12
@radical radical requested a review from lewing as a code owner February 1, 2023 06:12
@ghost
Copy link

ghost commented Feb 1, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. installer version.

  • This is only for running Wasm.Build.Tests

Two new properties are added:

  • SdkBandVersionForWorkload_ComputedFromInstaller: this is based on the version derived from dotnet --version. 8.0.0-alpha.1.1234.1 becomes 8.0.0-alpha.1, and is used as the path where the manifests get installed for testing: sdk-manifests/$(SdkBandVersionForWorkload_ComputedFromInstaller)

  • SdkBandVersionForWorkload_FromRuntimeVersions: this is the version band used for the packages generated. And simply rename of the earlier $(SdkBandVersionForWorkload).

Author: radical
Assignees: -
Labels:

arch-wasm, test-enhancement
Milestone: -

@ghost ghost assigned radical Feb 1, 2023
@ghost
Copy link

ghost commented Feb 1, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

.. installer version.

  • This is only for running Wasm.Build.Tests

Two new properties are added:

  • SdkBandVersionForWorkload_ComputedFromInstaller: this is based on the version derived from dotnet --version. 8.0.0-alpha.1.1234.1 becomes 8.0.0-alpha.1, and is used as the path where the manifests get installed for testing: sdk-manifests/$(SdkBandVersionForWorkload_ComputedFromInstaller)

  • SdkBandVersionForWorkload_FromRuntimeVersions: this is the version band used for the packages generated. And simply rename of the earlier $(SdkBandVersionForWorkload).

Author: radical
Assignees: -
Labels:

arch-wasm, test-enhancement, area-Infrastructure-mono
Milestone: -

This was referenced Feb 1, 2023
Closed
Closed
@lewing lewing merged commit b563df9 into dotnet:main Feb 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@steveisok steveisok Awaiting requested review from steveisok

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Infrastructure-mono test-enhancement Improvements of test source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radical @lewing