Enable same set of analyzers for C# tools that are used by the repo #81073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and resolve reported violations
marek-safar
requested review from
MichalStrehovsky,
radekdoulik and
sbomer
as code owners
|
Tagging subscribers to this area: @dotnet/area-meta Issue Detailsand resolve reported violations
|
stephentoub
reviewed
Jan 24, 2023
Contributor
Author
|
/cc @vitek-karas |
marek-safar
changed the title
marek-safar
force-pushed
the
illink-analyzer
branch
from
b607bca to
c2fcf38
Compare
marek-safar
force-pushed
the
illink-analyzer
branch
from
c2fcf38 to
4c236d0
Compare
tlakollo
reviewed
Feb 7, 2023
src/tools/illink/src/linker/Linker.Dataflow/MethodBodyScanner.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com>
vitek-karas
approved these changes
Feb 8, 2023
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
Other than the XML reading fix this looks good.
| => obj is LocalKey inst && Equals (inst); | ||
|
|
||
| public override int GetHashCode () | ||
| => CaptureId is null ? SymbolEqualityComparer.Default.GetHashCode (Local) : CaptureId.GetHashCode (); |
Member
There was a problem hiding this comment.
Nit: ideally the hash code would incorporate both the Local as well as the CaptureId.
Contributor
Author
There was a problem hiding this comment.
They are never set both at the same time.
src/tools/illink/src/ILLink.Tasks/CreateRuntimeRootDescriptorFile.cs
Outdated
Show resolved
Hide resolved
marek-safar
force-pushed
the
illink-analyzer
branch
from
76edff0 to
d2fed25
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and resolve reported violations