-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Set CMAKE_BUILD_TYPE=Checked in corehost #74065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsFIx dotnet/dotnet-api-docs#8315
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Yup, it was a wrong link, :) @EgorBo, could you test this patch? |
7143b83 to
b1c44b7
Compare
b1c44b7 to
20b75b8
Compare
|
Tagging subscribers to this area: @hoyosjs Issue DetailsFIx #74060
|
|
@am11 awesome! just checked and it works! |
|
Build break: I do not think that diverging debug and release builds this way is a good idea. |
|
Yes, I am looking into it. |
20b75b8 to
5ee2cdf
Compare
|
Unlike Unix, |
|
Is this just a discrepancy in where the version file gets generated (under checked since runtime/src/native/corehost/corehost.proj Line 125 in 1b4be3f
runtime/src/native/corehost/build.cmd Line 77 in 1b4be3f
If so, I think we should reconcile that rather than skipping the |
|
@elinor-fung we both commented at the same time. I found the rootcause why it only breaks on Windows. |
5ee2cdf to
3fc49dd
Compare
|
@EgorBo, @elinor-fung, this is a different fix. I haven't centralize |
|
Thanks for fixing this! It would be nice if someone could review this and merge asap, thanks |
|
Thanks, @am11! |
FIx #74060