Skip to content

Enable runtime-async feature switch for NativeAOT System.Private.CoreLib #123952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −0
Draft

Enable runtime-async feature switch for NativeAOT System.Private.CoreLib #123952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07af4b1
Initial plan
Copilot Feb 3, 2026
0bbc9b5
Enable runtime-async feature switch for NativeAOT System.Private.CoreLib
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@
<FeatureSharedLowLevelLock>true</FeatureSharedLowLevelLock>
</PropertyGroup>

<!-- Enable runtime async for Native AOT -->
<PropertyGroup>
<Features>$(Features);runtime-async=on</Features>
<!-- Suppress warnings for using methods that require opting into preview features (AsyncHelpers.Await calls) -->
<NoWarn>$(NoWarn);CA2252</NoWarn>
Copy link
Member

@VSadov VSadov Feb 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to suppress <NoWarn>$(NoWarn);SYSLIB5007</NoWarn> in #119432 as well. Possibly just a different way to suppress the same build errors?

I wonder what is the scenario when we see AsyncHelpers.Await marked as preview features?
I think they are no longer marked as experimental.

Copy link
Member

@VSadov VSadov Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My theory was that we were building something against net10, perhaps temporarily for some build/codeflow related reasons.

But maybe the reason is something else.

I did not look deeply, just disabled the warnings to get them out of the way, but I kind of wonder why we need to do this.

Copy link
Member

@MichalStrehovsky MichalStrehovsky Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this because we mark AsyncHelpers as RequiresPreviewFeatures?

runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.cs

Lines 72 to 73 in 84263e2

[RequiresPreviewFeatures]
public static T Await<T>(Task<T> task)

Copy link
Member

@VSadov VSadov Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. There is another marker.

@agocke - perhaps it is time to remove [RequiresPreviewFeatures]?
I assume we do not plan to ship with this?

</PropertyGroup>

<!-- Sources -->
<ItemGroup>
<Compile Include="$(CompilerCommonPath)\Internal\Runtime\DehydratedData.cs">
Expand Down
Loading