Skip to content

SVE: Add float/double args for mask APIs #123947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 1 commit into from
Feb 3, 2026
Merged

SVE: Add float/double args for mask APIs #123947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreclr/jit/fgdiagnostic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3428,10 +3428,12 @@ void Compiler::fgDebugCheckFlags(GenTree* tree, BasicBlock* block)
case NI_Sve_Prefetch64Bit:
case NI_Sve_Prefetch8Bit:
case NI_Sve_GetFfrByte:
case NI_Sve_GetFfrDouble:
case NI_Sve_GetFfrInt16:
case NI_Sve_GetFfrInt32:
case NI_Sve_GetFfrInt64:
case NI_Sve_GetFfrSByte:
case NI_Sve_GetFfrSingle:
case NI_Sve_GetFfrUInt16:
case NI_Sve_GetFfrUInt32:
case NI_Sve_GetFfrUInt64:
Expand Down
4 changes: 4 additions & 0 deletions src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28802,10 +28802,12 @@ bool GenTreeHWIntrinsic::OperRequiresCallFlag() const
case NI_Sve_GatherPrefetch64Bit:
case NI_Sve_GatherPrefetch8Bit:
case NI_Sve_GetFfrByte:
case NI_Sve_GetFfrDouble:
case NI_Sve_GetFfrInt16:
case NI_Sve_GetFfrInt32:
case NI_Sve_GetFfrInt64:
case NI_Sve_GetFfrSByte:
case NI_Sve_GetFfrSingle:
case NI_Sve_GetFfrUInt16:
case NI_Sve_GetFfrUInt32:
case NI_Sve_GetFfrUInt64:
Expand Down Expand Up @@ -29020,10 +29022,12 @@ void GenTreeHWIntrinsic::Initialize(NamedIntrinsic intrinsicId)
case NI_Sve_Prefetch64Bit:
case NI_Sve_Prefetch8Bit:
case NI_Sve_GetFfrByte:
case NI_Sve_GetFfrDouble:
case NI_Sve_GetFfrInt16:
case NI_Sve_GetFfrInt32:
case NI_Sve_GetFfrInt64:
case NI_Sve_GetFfrSByte:
case NI_Sve_GetFfrSingle:
case NI_Sve_GetFfrUInt16:
case NI_Sve_GetFfrUInt32:
case NI_Sve_GetFfrUInt64:
Expand Down
22 changes: 12 additions & 10 deletions src/coreclr/jit/hwintrinsiclistarm64sve.h
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/coreclr/jit/lowerarmarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,10 +1875,12 @@ GenTree* Lowering::LowerHWIntrinsic(GenTreeHWIntrinsic* node)
}

case NI_Sve_GetFfrByte:
case NI_Sve_GetFfrDouble:
case NI_Sve_GetFfrInt16:
case NI_Sve_GetFfrInt32:
case NI_Sve_GetFfrInt64:
case NI_Sve_GetFfrSByte:
case NI_Sve_GetFfrSingle:
case NI_Sve_GetFfrUInt16:
case NI_Sve_GetFfrUInt32:
case NI_Sve_GetFfrUInt64:
Expand Down
132 changes: 132 additions & 0 deletions ...ries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2086,6 +2086,12 @@ internal Arm64() { }

// Break after first true condition

/// <summary>
/// <para>svbool_t svbrka[_b]_z(svbool_t pg, svbool_t op)</para>
/// <para> BRKA Presult.B, Pg/Z, Pop.B</para>
/// </summary>
public static Vector<double> CreateBreakAfterMask(Vector<double> totalMask, Vector<double> fromMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svbrka[_b]_z(svbool_t pg, svbool_t op)</para>
/// <para> BRKA Presult.B, Pg/Z, Pop.B</para>
Expand Down Expand Up @@ -2134,9 +2140,21 @@ internal Arm64() { }
/// </summary>
public static Vector<ulong> CreateBreakAfterMask(Vector<ulong> totalMask, Vector<ulong> fromMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svbrka[_b]_z(svbool_t pg, svbool_t op)</para>
/// <para> BRKA Presult.B, Pg/Z, Pop.B</para>
/// </summary>
public static Vector<float> CreateBreakAfterMask(Vector<float> totalMask, Vector<float> fromMask) { throw new PlatformNotSupportedException(); }


// Break after first true condition, propagating from previous partition

/// <summary>
/// <para>svbool_t svbrkpa[_b]_z(svbool_t pg, svbool_t op1, svbool_t op2)</para>
/// <para> BRKPA Presult.B, Pg/Z, Pop1.B, Pop2.B</para>
/// </summary>
public static Vector<double> CreateBreakAfterPropagateMask(Vector<double> mask, Vector<double> left, Vector<double> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svbrkpa[_b]_z(svbool_t pg, svbool_t op1, svbool_t op2)</para>
/// <para> BRKPA Presult.B, Pg/Z, Pop1.B, Pop2.B</para>
Expand Down Expand Up @@ -2185,9 +2203,21 @@ internal Arm64() { }
/// </summary>
public static Vector<ulong> CreateBreakAfterPropagateMask(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svbrkpa[_b]_z(svbool_t pg, svbool_t op1, svbool_t op2)</para>
/// <para> BRKPA Presult.B, Pg/Z, Pop1.B, Pop2.B</para>
/// </summary>
public static Vector<float> CreateBreakAfterPropagateMask(Vector<float> mask, Vector<float> left, Vector<float> right) { throw new PlatformNotSupportedException(); }


// Break before first true condition

/// <summary>
/// <para>svbool_t svbrkb[_b]_z(svbool_t pg, svbool_t op)</para>
/// <para> BRKB Presult.B, Pg/Z, Pop.B</para>
/// </summary>
public static Vector<double> CreateBreakBeforeMask(Vector<double> totalMask, Vector<double> fromMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svbrkb[_b]_z(svbool_t pg, svbool_t op)</para>
/// <para> BRKB Presult.B, Pg/Z, Pop.B</para>
Expand Down Expand Up @@ -2236,9 +2266,21 @@ internal Arm64() { }
/// </summary>
public static Vector<ulong> CreateBreakBeforeMask(Vector<ulong> totalMask, Vector<ulong> fromMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svbrkb[_b]_z(svbool_t pg, svbool_t op)</para>
/// <para> BRKB Presult.B, Pg/Z, Pop.B</para>
/// </summary>
public static Vector<float> CreateBreakBeforeMask(Vector<float> totalMask, Vector<float> fromMask) { throw new PlatformNotSupportedException(); }


// Break before first true condition, propagating from previous partition

/// <summary>
/// <para>svbool_t svbrkpb[_b]_z(svbool_t pg, svbool_t op1, svbool_t op2)</para>
/// <para> BRKPB Presult.B, Pg/Z, Pop1.B, Pop2.B</para>
/// </summary>
public static Vector<double> CreateBreakBeforePropagateMask(Vector<double> mask, Vector<double> left, Vector<double> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svbrkpb[_b]_z(svbool_t pg, svbool_t op1, svbool_t op2)</para>
/// <para> BRKPB Presult.B, Pg/Z, Pop1.B, Pop2.B</para>
Expand Down Expand Up @@ -2287,9 +2329,21 @@ internal Arm64() { }
/// </summary>
public static Vector<ulong> CreateBreakBeforePropagateMask(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svbrkpb[_b]_z(svbool_t pg, svbool_t op1, svbool_t op2)</para>
/// <para> BRKPB Presult.B, Pg/Z, Pop1.B, Pop2.B</para>
/// </summary>
public static Vector<float> CreateBreakBeforePropagateMask(Vector<float> mask, Vector<float> left, Vector<float> right) { throw new PlatformNotSupportedException(); }


// Propagate break to next partition

/// <summary>
/// <para>svbool_t svbrkn[_b]_z(svbool_t pg, svbool_t op1, svbool_t op2)</para>
/// <para> BRKN Ptied2.B, Pg/Z, Pop1.B, Ptied2.B</para>
/// </summary>
public static Vector<double> CreateBreakPropagateMask(Vector<double> totalMask, Vector<double> fromMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svbrkn[_b]_z(svbool_t pg, svbool_t op1, svbool_t op2)</para>
/// <para> BRKN Ptied2.B, Pg/Z, Pop1.B, Ptied2.B</para>
Expand Down Expand Up @@ -2338,6 +2392,12 @@ internal Arm64() { }
/// </summary>
public static Vector<ulong> CreateBreakPropagateMask(Vector<ulong> totalMask, Vector<ulong> fromMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svbrkn[_b]_z(svbool_t pg, svbool_t op1, svbool_t op2)</para>
/// <para> BRKN Ptied2.B, Pg/Z, Pop1.B, Ptied2.B</para>
/// </summary>
public static Vector<float> CreateBreakPropagateMask(Vector<float> totalMask, Vector<float> fromMask) { throw new PlatformNotSupportedException(); }


// Set all predicate elements to false

Expand Down Expand Up @@ -2431,6 +2491,12 @@ internal Arm64() { }

// Set the first active predicate element to true

/// <summary>
/// <para>svbool_t svpfirst[_b](svbool_t pg, svbool_t op)</para>
/// <para> PFIRST Ptied.B, Pg, Ptied.B</para>
/// </summary>
public static Vector<double> CreateMaskForFirstActiveElement(Vector<double> totalMask, Vector<double> fromMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svpfirst[_b](svbool_t pg, svbool_t op)</para>
/// <para> PFIRST Ptied.B, Pg, Ptied.B</para>
Expand Down Expand Up @@ -2479,6 +2545,12 @@ internal Arm64() { }
/// </summary>
public static Vector<ulong> CreateMaskForFirstActiveElement(Vector<ulong> totalMask, Vector<ulong> fromMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svpfirst[_b](svbool_t pg, svbool_t op)</para>
/// <para> PFIRST Ptied.B, Pg, Ptied.B</para>
/// </summary>
public static Vector<float> CreateMaskForFirstActiveElement(Vector<float> totalMask, Vector<float> fromMask) { throw new PlatformNotSupportedException(); }


// Find next active predicate

Expand Down Expand Up @@ -5341,6 +5413,12 @@ internal Arm64() { }
/// </summary>
public static Vector<byte> GetFfrByte() { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svrdffr()</para>
/// <para> RDFFR Presult.B</para>
/// </summary>
public static Vector<double> GetFfrDouble() { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svrdffr()</para>
/// <para> RDFFR Presult.B</para>
Expand All @@ -5365,6 +5443,12 @@ internal Arm64() { }
/// </summary>
public static Vector<sbyte> GetFfrSByte() { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svrdffr()</para>
/// <para> RDFFR Presult.B</para>
/// </summary>
public static Vector<float> GetFfrSingle() { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>svbool_t svrdffr()</para>
/// <para> RDFFR Presult.B</para>
Expand Down Expand Up @@ -9154,6 +9238,12 @@ internal Arm64() { }

// Write to the first-fault register

/// <summary>
/// <para>void svwrffr(svbool_t op)</para>
/// <para> WRFFR Pop.B</para>
/// </summary>
public static void SetFfr(Vector<double> value) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>void svwrffr(svbool_t op)</para>
/// <para> WRFFR Pop.B</para>
Expand Down Expand Up @@ -9202,6 +9292,12 @@ internal Arm64() { }
/// </summary>
public static void SetFfr(Vector<ulong> value) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>void svwrffr(svbool_t op)</para>
/// <para> WRFFR Pop.B</para>
/// </summary>
public static void SetFfr(Vector<float> value) { throw new PlatformNotSupportedException(); }


// Logical shift left

Expand Down Expand Up @@ -10169,6 +10265,12 @@ internal Arm64() { }

// Test whether any active element is true

/// <summary>
/// <para>bool svptest_any(svbool_t pg, svbool_t op)</para>
/// <para> PTEST</para>
/// </summary>
public static bool TestAnyTrue(Vector<double> mask, Vector<double> rightMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>bool svptest_any(svbool_t pg, svbool_t op)</para>
/// <para> PTEST</para>
Expand Down Expand Up @@ -10217,9 +10319,21 @@ internal Arm64() { }
/// </summary>
public static bool TestAnyTrue(Vector<ulong> mask, Vector<ulong> rightMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>bool svptest_any(svbool_t pg, svbool_t op)</para>
/// <para> PTEST</para>
/// </summary>
public static bool TestAnyTrue(Vector<float> mask, Vector<float> rightMask) { throw new PlatformNotSupportedException(); }


// Test whether the first active element is true

/// <summary>
/// <para>bool svptest_first(svbool_t pg, svbool_t op)</para>
/// <para> PTEST</para>
/// </summary>
public static bool TestFirstTrue(Vector<double> leftMask, Vector<double> rightMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>bool svptest_first(svbool_t pg, svbool_t op)</para>
/// <para> PTEST</para>
Expand Down Expand Up @@ -10268,9 +10382,21 @@ internal Arm64() { }
/// </summary>
public static bool TestFirstTrue(Vector<ulong> leftMask, Vector<ulong> rightMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>bool svptest_first(svbool_t pg, svbool_t op)</para>
/// <para> PTEST</para>
/// </summary>
public static bool TestFirstTrue(Vector<float> leftMask, Vector<float> rightMask) { throw new PlatformNotSupportedException(); }


// Test whether the last active element is true

/// <summary>
/// <para>bool svptest_last(svbool_t pg, svbool_t op)</para>
/// <para> PTEST</para>
/// </summary>
public static bool TestLastTrue(Vector<double> leftMask, Vector<double> rightMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>bool svptest_last(svbool_t pg, svbool_t op)</para>
/// <para> PTEST</para>
Expand Down Expand Up @@ -10319,6 +10445,12 @@ internal Arm64() { }
/// </summary>
public static bool TestLastTrue(Vector<ulong> leftMask, Vector<ulong> rightMask) { throw new PlatformNotSupportedException(); }

/// <summary>
/// <para>bool svptest_last(svbool_t pg, svbool_t op)</para>
/// <para> PTEST</para>
/// </summary>
public static bool TestLastTrue(Vector<float> leftMask, Vector<float> rightMask) { throw new PlatformNotSupportedException(); }


// Interleave even elements from two inputs

Expand Down
Loading
Loading