Add intrinsic recognition for Type.GetGenericTypeDefinition #123460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type.GetGenericTypeDefinition()was not intrinsically recognized by ILLink trimming analysis, preventing annotation propagation in patterns like dependency injection where generic type definitions are used for service lookups.Changes
Core intrinsic recognition:
Type_GetGenericTypeDefinitiontoIntrinsicIdenumIntrinsics.csto detectGetGenericTypeDefinition()callsHandleCallAction.csthat propagates allDynamicallyAccessedMemberTypesannotationsPlatform implementations:
GenericInstanceType.ElementType→TypeDefinitionINamedTypeSymbol.OriginalDefinitionInstantiatedType.GetTypeDefinition()Key behavior: Unlike
BaseTypewhich selectively propagates annotations,GetGenericTypeDefinition()propagates all annotations since the generic type definition contains identical members to the constructed type.Example
Testing
GetGenericTypeDefinitionDataFlowtest covering annotation propagation scenariosDependencyInjectionPatterntest now works correctlyOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.