[release/10.0] Don't flush data in DeflateStream.FlushAsync if no data was written#121796
Closed
rzikm wants to merge 1 commit intodotnet:release/10.0from
Closed
[release/10.0] Don't flush data in DeflateStream.FlushAsync if no data was written#121796rzikm wants to merge 1 commit intodotnet:release/10.0from
rzikm wants to merge 1 commit intodotnet:release/10.0from
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
rzikm
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in DeflateStream and GZipStream where calling FlushAsync without writing any data could produce a non-empty partial payload that doesn't decompress correctly. The fix ensures consistency between the sync and async flush implementations.
Key Changes
- Added
if (_wroteBytes)check to the asyncFlushAsyncmethod to match the existing syncFlushbehavior - Prevents compression operations when no data has been written to the stream
alinpahontu2912
approved these changes
Nov 19, 2025
Member
Author
|
We will not service this change, not enough business justification |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121710.
Customer Impact
Certain valid code patterns using DeflateStream and GZipStream may produce invalid bytes when compressing empty input. The invalid output then cannot be correctly decompressed by 3rd party tools.
Workarounds are either not using async path or ensuring FlushAsync is not called by user code if nothing was written to the stream.
Regression
Behavior differs w.r.t. .NET 8.
The bug has been fixed for .NET 11 by #118570
Testing
Tested scenario reported by customer. Additional validation is provided by CI
Risk
Low, fix is small and the root cause is well understood.