Fix unicode tests for ios/tvOs by alinpahontu2912 · Pull Request #119459 · dotnet/runtime

alinpahontu2912 · 2025-09-08T11:57:30Z

Normalize extra ascii characters to perform correct matching on apple platforms

Copilot

Pull Request Overview

This PR temporarily enables unicode-related tests for iOS/tvOS platforms by removing [ActiveIssue] attributes that were previously skipping these tests. The purpose is to check if the tests are still failing for debugging purposes as part of work on issue #72951.

Key changes:

Removal of test skipping attributes for iOS/tvOS platforms on unicode-related tests
Enables previously disabled tests to run and provide current status information

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
ZipFileExtensions.ZipArchive.Extract.cs	Removes ActiveIssue attribute from ExtractToDirectoryExtension_Unicode test
ZipFile.Extract.cs	Removes ActiveIssue attribute from ExtractToDirectoryUnicode test
ZipFile.Extract.Stream.cs	Removes ActiveIssue attribute from ExtractToDirectoryUnicode test

akoeplinger · 2025-09-08T14:22:44Z

Note that we only run smoke tests for iOS/tvOS in PRs by default which doesn't include System.IO.Compression so you'd need to trigger the full pipeline.

rzikm · 2025-09-09T07:54:53Z

/azp list

azure-pipelines · 2025-09-09T07:54:59Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-android-grpc-client-tests runtime-wasm-non-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-wasm-optional runtime-nativeaot-outerloop runtime-coreclr superpmi-collect-test runtime-diagnostics runtime-interpreter

rzikm · 2025-09-09T07:56:17Z

/azp run runtime-ioslike

azure-pipelines · 2025-09-09T07:56:25Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

rzikm · 2025-09-09T07:57:00Z

/azp run runtime-extra-platforms

azure-pipelines · 2025-09-09T07:57:20Z

Azure Pipelines successfully started running 1 pipeline(s).

alinpahontu2912 · 2025-09-10T08:49:21Z

Test was failing because iOS/tvOS store filenames in decomposed form NFD and we were comparing against NFC words. They look the same but compare different, so we should normalize for them to match.

src/libraries/Common/tests/System/IO/Compression/ZipTestHelper.cs

rzikm · 2025-09-11T14:32:22Z

/azp run runtime-extra-platforms

azure-pipelines · 2025-09-11T14:32:43Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/Common/tests/System/IO/Compression/ZipTestHelper.cs

alinpahontu2912 · 2025-09-25T10:08:07Z

/azp run runtime-extra-platforms

azure-pipelines · 2025-09-25T10:08:22Z

Azure Pipelines successfully started running 1 pipeline(s).

…ison

alinpahontu2912 · 2025-09-25T13:05:58Z

/azp run runtime-extra-platforms

azure-pipelines · 2025-09-25T13:06:11Z

Azure Pipelines successfully started running 1 pipeline(s).

alinpahontu2912 · 2025-09-26T07:39:44Z

/azp run runtime-extra-platforms

azure-pipelines · 2025-09-26T07:39:57Z

Azure Pipelines successfully started running 1 pipeline(s).

rzikm

LGTM

src/libraries/Common/tests/System/IO/Compression/ZipTestHelper.cs

alinpahontu2912 · 2025-09-26T11:28:58Z

/azp run runtime-extra-platforms

azure-pipelines · 2025-09-26T11:29:11Z

Azure Pipelines successfully started running 1 pipeline(s).

alinpahontu2912 · 2025-09-29T12:36:44Z

/ba-g build failure is unrelated

temporarily enable failing test for debug

db48d7f

github-actions bot added the area-System.IO.Compression label Sep 8, 2025

dotnet-policy-service bot assigned alinpahontu2912 Sep 8, 2025

alinpahontu2912 marked this pull request as ready for review September 8, 2025 14:00

Copilot AI review requested due to automatic review settings September 8, 2025 14:00

alinpahontu2912 added the os-ios Apple iOS label Sep 8, 2025

Copilot AI reviewed Sep 8, 2025

View reviewed changes

alinpahontu2912 added the os-tvos Apple tvOS label Sep 8, 2025

attempt to fix unicode failure

a410abd

build-analysis bot mentioned this pull request Sep 9, 2025

XHarness message of order error leading to timeout dotnet/dnceng#4823

Closed

3 tasks

rzikm reviewed Sep 10, 2025

View reviewed changes

src/libraries/Common/tests/System/IO/Compression/ZipTestHelper.cs Outdated Show resolved Hide resolved

remove string normalization method

549163f

build-analysis bot mentioned this pull request Sep 11, 2025

Unable to pull image from mcr.microsoft.com #117164

Open

rzikm reviewed Sep 11, 2025

View reviewed changes

src/libraries/Common/tests/System/IO/Compression/ZipTestHelper.cs Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Sep 11, 2025

[Long Running Test] 'System.Composition.UnitTests.ConcurrencyTests.SharedInstancesAreNotVisibleUntilActivationCompletes' #113686

Open

build-analysis bot mentioned this pull request Sep 11, 2025

Android tests fail with INSTALL_FAILED_INSUFFICIENT_STORAGE #118090

Closed

fix platform check

0dada05

alinpahontu2912 changed the title ~~[DRAFT] Temporarily enable unicode tests for ios/tvOs~~ Fix unicode tests for ios/tvOs Sep 25, 2025

rzikm reviewed Sep 25, 2025

View reviewed changes

src/libraries/Common/tests/System/IO/Compression/ZipTestHelper.cs Outdated Show resolved Hide resolved

add comment explaining change

57a45e7

Revert form normalization and perform invariant culture string compar…

26ebce6

…ison

build-analysis bot mentioned this pull request Sep 25, 2025

AppHost tests fail with "Failure extracting contents of the application bundle." #119249

Closed

normalize both entries for comparison

5355032

build-analysis bot mentioned this pull request Sep 26, 2025

CreateBroadcasting_AllMethodsOverridden test fails on many legs #120137

Closed

rzikm approved these changes Sep 26, 2025

View reviewed changes

src/libraries/Common/tests/System/IO/Compression/ZipTestHelper.cs Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Sep 26, 2025

[browser] HalfTests.ExplicitConversion_FromSingle failing due to NaN != NaN #103347

Open

add platform check

490ab3a

build-analysis bot mentioned this pull request Sep 26, 2025

browser-wasm linux Release LibraryTests queues timing out #117974

Open

alinpahontu2912 enabled auto-merge (squash) September 29, 2025 12:35

alinpahontu2912 merged commit 7505d8f into dotnet:main Sep 29, 2025
105 of 143 checks passed

alinpahontu2912 deleted the unicode_issue_ios branch October 20, 2025 08:08

github-actions bot locked and limited conversation to collaborators Nov 19, 2025

Conversation

alinpahontu2912 commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

akoeplinger commented Sep 8, 2025

Uh oh!

rzikm commented Sep 9, 2025

Uh oh!

azure-pipelines bot commented Sep 9, 2025

Uh oh!

rzikm commented Sep 9, 2025

Uh oh!

azure-pipelines bot commented Sep 9, 2025

Uh oh!

rzikm commented Sep 9, 2025

Uh oh!

azure-pipelines bot commented Sep 9, 2025

Uh oh!

alinpahontu2912 commented Sep 10, 2025

Uh oh!

Uh oh!

rzikm commented Sep 11, 2025

Uh oh!

azure-pipelines bot commented Sep 11, 2025

Uh oh!

Uh oh!

Uh oh!

alinpahontu2912 commented Sep 25, 2025

Uh oh!

azure-pipelines bot commented Sep 25, 2025

Uh oh!

alinpahontu2912 commented Sep 25, 2025

Uh oh!

azure-pipelines bot commented Sep 25, 2025

Uh oh!

alinpahontu2912 commented Sep 26, 2025

Uh oh!

azure-pipelines bot commented Sep 26, 2025

Uh oh!

rzikm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alinpahontu2912 commented Sep 26, 2025

Uh oh!

azure-pipelines bot commented Sep 26, 2025

Uh oh!

alinpahontu2912 commented Sep 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alinpahontu2912 commented Sep 8, 2025 •

edited

Loading