Skip SSL key log test for OpenSSL 3.5+#116474
Merged
rokonec merged 3 commits intodotnet:mainfrom Jun 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR skips the SSL key log file creation test when running against OpenSSL 3.5 or later, addressing false failures due to the library’s relaxed behavior.
- Updated SslStreamRemoteExecutorTests to bypass the test for OpenSSL versions 3.5+
- Added inline comments referencing the change and future revisit via issue #116473
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamRemoteExecutorTests.cs:37
- Consider using an explicit test skip attribute or helper instead of an early return to indicate that the test is intentionally skipped for OpenSSL 3.5+ scenarios. This approach can improve clarity in test reports and maintain consistency with other skipped tests.
if (PlatformDetection.IsOpenSslSupported && PlatformDetection.OpenSslVersion >= new Version(3, 5, 0))
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
ManickaP
reviewed
Jun 10, 2025
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamRemoteExecutorTests.cs
Outdated
Show resolved
Hide resolved
vcsjones
reviewed
Jun 10, 2025
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamRemoteExecutorTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 10, 2025
Member
Author
|
/backport to release/9.0-staging |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/15679821163 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
OpenSSL 3.5.0 supports SSLKEYLOGFILE with just an environment variable, which is less strict than .NET's requirements. There's no way to check if this feature is enabled in the OpenSSL library, so we should disable the test based on the OpenSSL version for now.
Affected tests
System.Net.Security.Tests.SslStreamRemoteExecutorTests.SslKeyLogFile_IsCreatedAndFilledTesting
Fix verified on previously stable failing CentOS 10 docker image
mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream-10-helix-amd64Notes
#116473 has been create to revisit it in future, lets say a year